135781 - Use flat strings when constructing string keys

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Doug Turner (:dougt)]

There are a few high volume calls which create a string key with a string which
outlives the life of the key.  In these places, we should ensure that the key is
created such that only a clone will copy the string.

Comment 1

[Doug Turner (:dougt)]

Attachment: fixes a few high volume callers

Comment 2

[Suresh Duddi (gone)]

Comment on attachment 78403 [details] [diff] [review]
fixes a few high volume callers

r=dp

Comment 3

[Darin Fisher]

Comment on attachment 78403 [details] [diff] [review]
fixes a few high volume callers

sr=darin

the alternative i guess would be to add a |const nsPromiseFlatString&| member
variable to nsStringKey, and call PromiseFlatString from within the
constructor.  i'm assuming we don't want to bloat nsStringKey by 4-bytes when
the |const nsAString&| constructor is not used.  makes sense.

Comment 4

[Doug Turner (:dougt)]

Checking in content/base/src/nsNameSpaceManager.cpp;
/cvsroot/mozilla/content/base/src/nsNameSpaceManager.cpp,v  <-- 
nsNameSpaceManager.cpp
new revision: 3.34; previous revision: 3.33
done
Checking in content/events/src/nsEventListenerManager.cpp;
/cvsroot/mozilla/content/events/src/nsEventListenerManager.cpp,v  <-- 
nsEventListenerManager.cpp
new revision: 1.123; previous revision: 1.122
done
Checking in content/xul/document/src/nsControllerCommandManager.cpp;
/cvsroot/mozilla/content/xul/document/src/nsControllerCommandManager.cpp,v  <--
 nsControllerCommandManager.cpp
new revision: 1.9; previous revision: 1.8
done
Checking in layout/base/src/nsPresState.cpp;
/cvsroot/mozilla/layout/base/src/nsPresState.cpp,v  <--  nsPresState.cpp
new revision: 3.14; previous revision: 3.13
done
Checking in xpcom/ds/nsStaticNameTable.cpp;
/cvsroot/mozilla/xpcom/ds/nsStaticNameTable.cpp,v  <--  nsStaticNameTable.cpp
new revision: 1.12; previous revision: 1.11
done

Thanks.