Use standard CSS border instead of -moz-border-*-colors in eula.css

RESOLVED FIXED in Firefox 55

Status

()

Toolkit
Themes
RESOLVED FIXED
a month ago
a month ago

People

(Reporter: dao, Assigned: frankanthonyserrano, Mentored)

Tracking

({good-first-bug})

Trunk
mozilla55
good-first-bug
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

(Whiteboard: [good first bug][lang=css])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

a month ago
Thanks to bug 482692, we can just use "border: 1px solid ActiveBorder;" and get rid of -moz-border-*-colors here:

http://searchfox.org/mozilla-central/rev/214345204f1e7d97abb571b7992b6deedb5ff98f/toolkit/themes/windows/mozapps/extensions/eula.css#36

and:

http://searchfox.org/mozilla-central/rev/214345204f1e7d97abb571b7992b6deedb5ff98f/toolkit/themes/osx/mozapps/extensions/eula.css#36
(Assignee)

Comment 1

a month ago
I am going to work on this one, I'll update soon
Comment hidden (mozreview-request)
(Assignee)

Comment 3

a month ago
All right, I have attached a patch
(Reporter)

Comment 4

a month ago
mozreview-review
Comment on attachment 8859817 [details]
Bug 1357832 - Update eula.css to use standard css border;

https://reviewboard.mozilla.org/r/131802/#review134746

Perfect, thanks!
Attachment #8859817 - Flags: review?(dao+bmo) → review+
(Reporter)

Updated

a month ago
Assignee: nobody → frankanthonyserrano

Comment 5

a month ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/12f943a6d12c
Update eula.css to use standard css border; r=dao
(Assignee)

Comment 6

a month ago
This is my first bug, are there any next steps for me to do? Looking at the documentation I'm supposed to push it to the try server, but I don't have try server credentials and I think you've pushed it already.
(Reporter)

Comment 7

a month ago
The patch has already landed on an integration branch. We don't need a try run for this simple patch.
https://hg.mozilla.org/mozilla-central/rev/12f943a6d12c
Status: NEW → RESOLVED
Last Resolved: a month ago
status-firefox55: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.