1357832 - Use standard CSS border instead of -moz-border-*-colors in eula.css

Status: RESOLVED FIXED

(Toolkit :: Themes, enhancement)

Description

[Dão Gottwald [::dao]]

Thanks to bug 482692, we can just use "border: 1px solid ActiveBorder;" and get rid of -moz-border-*-colors here:

http://searchfox.org/mozilla-central/rev/214345204f1e7d97abb571b7992b6deedb5ff98f/toolkit/themes/windows/mozapps/extensions/eula.css#36

and:

http://searchfox.org/mozilla-central/rev/214345204f1e7d97abb571b7992b6deedb5ff98f/toolkit/themes/osx/mozapps/extensions/eula.css#36

Comment 1

[frankanthonyserrano]

I am going to work on this one, I'll update soon

Comment 2

[frankanthonyserrano]

Attachment: Bug 1357832 - Update eula.css to use standard css border;

We were using -moz-border-*-colors in eula.css before.
We no longer need to do that, so we are changing it to use the standard css border

Review commit: https://reviewboard.mozilla.org/r/131802/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/131802/

Comment 3

[frankanthonyserrano]

All right, I have attached a patch

Comment 4

[Dão Gottwald [::dao]]

Comment on attachment 8859817 [details]
Bug 1357832 - Update eula.css to use standard css border;

https://reviewboard.mozilla.org/r/131802/#review134746

Perfect, thanks!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/12f943a6d12c
Update eula.css to use standard css border; r=dao

Comment 6

[frankanthonyserrano]

This is my first bug, are there any next steps for me to do? Looking at the documentation I'm supposed to push it to the try server, but I don't have try server credentials and I think you've pushed it already.

Comment 7

[Dão Gottwald [::dao]]

The patch has already landed on an integration branch. We don't need a try run for this simple patch.

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/12f943a6d12c