1357873 - Fix printf format strings on AArch64 Android

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Fix up 64-bit Android macros in IntegerPrintfMacros.h (v1)

On 64-bit Android, the inttypes.h macros for [u]int_fastN_t types (e.g.
int_fast16_t) use "d", "u", etc. as the format specifier, but the types
themselves are defined as `long`, `unsigned long`, etc. This patch
redefines the macros as `PRId64`, `PRIu64`, etc. to provide correct
behavior.

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Fix format warning in gfx (v1)

Use printf macros to accommodate AArch64 types.

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Fix format warning in omx-plugin (v1)

Use printf macros to fix format warnings on AArch64.

Comment 4

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Fix format warning in webrtc (v1)

Use printf macros to fix format warnings on AArch64.

Comment 5

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8862534 [details] [diff] [review]
Fix format warning in omx-plugin (v1)

Review of attachment 8862534 [details] [diff] [review]:
-----------------------------------------------------------------

Please use mozreview.

Comment 6

[Jeff Walden [:Waldo]]

Comment on attachment 8862532 [details] [diff] [review]
Fix up 64-bit Android macros in IntegerPrintfMacros.h (v1)

Review of attachment 8862532 [details] [diff] [review]:
-----------------------------------------------------------------

Ugh.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8c4a408ed9e2
Fix up 64-bit Android macros in IntegerPrintfMacros.h; r=Waldo
https://hg.mozilla.org/integration/mozilla-inbound/rev/3d7080f299bd
Fix format warning in gfx; r=heycam
https://hg.mozilla.org/integration/mozilla-inbound/rev/ae1244b66761
Fix format warning in omx-plugin; r=cpearce
https://hg.mozilla.org/integration/mozilla-inbound/rev/60ef42b05139
Fix format warning in webrtc; r=jesup

Comment 8

[Iris Hsiao [:ihsiao]]

https://hg.mozilla.org/mozilla-central/rev/8c4a408ed9e2
https://hg.mozilla.org/mozilla-central/rev/3d7080f299bd
https://hg.mozilla.org/mozilla-central/rev/ae1244b66761
https://hg.mozilla.org/mozilla-central/rev/60ef42b05139