Closed Bug 1357873 Opened 3 years ago Closed 3 years ago

Fix printf format strings on AArch64 Android

Categories

(Firefox for Android :: General, defect)

Other
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 55
Tracking Status
firefox55 --- fixed

People

(Reporter: jchen, Assigned: jchen)

References

(Blocks 1 open bug)

Details

Attachments

(4 files)

No description provided.
On 64-bit Android, the inttypes.h macros for [u]int_fastN_t types (e.g.
int_fast16_t) use "d", "u", etc. as the format specifier, but the types
themselves are defined as `long`, `unsigned long`, etc. This patch
redefines the macros as `PRId64`, `PRIu64`, etc. to provide correct
behavior.
Attachment #8862532 - Flags: review?(jwalden+bmo)
Use printf macros to accommodate AArch64 types.
Attachment #8862533 - Flags: review?(cam)
Use printf macros to fix format warnings on AArch64.
Attachment #8862534 - Flags: review?(cpearce)
Use printf macros to fix format warnings on AArch64.
Attachment #8862535 - Flags: review?(rjesup)
Comment on attachment 8862534 [details] [diff] [review]
Fix format warning in omx-plugin (v1)

Review of attachment 8862534 [details] [diff] [review]:
-----------------------------------------------------------------

Please use mozreview.
Attachment #8862534 - Flags: review?(cpearce) → review+
Comment on attachment 8862532 [details] [diff] [review]
Fix up 64-bit Android macros in IntegerPrintfMacros.h (v1)

Review of attachment 8862532 [details] [diff] [review]:
-----------------------------------------------------------------

Ugh.
Attachment #8862532 - Flags: review?(jwalden+bmo) → review+
Attachment #8862533 - Flags: review?(cam) → review+
Attachment #8862535 - Flags: review?(rjesup) → review+
Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8c4a408ed9e2
Fix up 64-bit Android macros in IntegerPrintfMacros.h; r=Waldo
https://hg.mozilla.org/integration/mozilla-inbound/rev/3d7080f299bd
Fix format warning in gfx; r=heycam
https://hg.mozilla.org/integration/mozilla-inbound/rev/ae1244b66761
Fix format warning in omx-plugin; r=cpearce
https://hg.mozilla.org/integration/mozilla-inbound/rev/60ef42b05139
Fix format warning in webrtc; r=jesup
You need to log in before you can comment on or make changes to this bug.