1357874 - Add more JS support for AArch64 Android

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement)

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Fix errors/warnings in vixl (v1)

* Fix unused-result warnings when compiling vixl for android-aarch64.

* Fix an unused-variable warning when compiling in non-DEBUG builds.

* Fix the unreachable macro in non-DEBUG builds to avoid no-return
  errors in some functions using the unreachable macro.

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Add more AArch64 support to JS code (v1)

* Fix a parentheses warning when compiling testGCAllocator.cpp.

* Define GETRANDOM_NR macro for AArch64.

* Disable Android workarounds in jsnativestack.cpp and
  WasmSignalHandlers.cpp for AArch64, because AArch64 is only supported
  on API 21+, in which case those workarounds don't apply.

* Enable trace logging in TraceLogging.cpp.

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Disable RegExp JIT for AArch64 (v1)

I encountered crashes in jitted regexp code in my AArch64 Fennec build.
This patch disables that for now, but obviously we want to look into the
crashes and eventually turn this back on.

Comment 4

[Nicolas B. Pierron [:nbp]]

Comment on attachment 8859714 [details] [diff] [review]
Fix errors/warnings in vixl (v1)

Review of attachment 8859714 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/arm64/MacroAssembler-arm64.cpp
@@ +683,5 @@
>      stackForCall += ComputeByteAlignment(stackForCall, StackAlignment);
>      *stackAdjust = stackForCall;
>      reserveStack(*stackAdjust);
>      {
> +        mozilla::Unused << moveResolver_.resolve();

"MOZ_MUST_USE bool" is made to be used and not ignored, follow the same logic as done on x64.
Ignoring any of these errors can easily lead to exploitable security issue.

http://searchfox.org/mozilla-central/source/js/src/jit/x64/MacroAssembler-x64.cpp#488-490

Comment 5

[Sean Stangl [:sstangl]]

This patch has some overlap with the patch in Bug 1356709.

Comment 6

[(inactive) Jim Chen [:jchen] [:darchons]]

(In reply to Sean Stangl [:sstangl] from comment #5)
> This patch has some overlap with the patch in Bug 1356709.

Ok I'll wait for that to land.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/042d975f9355
Add more AArch64 support to JS code; r=luke
https://hg.mozilla.org/integration/mozilla-inbound/rev/c2f3dec3544d
Disable RegExp JIT for AArch64; r=snorp

Comment 9

[Iris Hsiao [:ihsiao]]

https://hg.mozilla.org/mozilla-central/rev/042d975f9355
https://hg.mozilla.org/mozilla-central/rev/c2f3dec3544d