Port bug 1286934 - switch to sccache2 and bug 1354048 - update sccache to SeaMonkey

RESOLVED FIXED in seamonkey2.52

Status

SeaMonkey
Build Config
RESOLVED FIXED
2 months ago
2 months ago

People

(Reporter: Ian Neal, Assigned: Ian Neal)

Tracking

Trunk
seamonkey2.52

SeaMonkey Tracking Flags

(seamonkey2.52 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 months ago
Bug 1286934 - Switch automation build jobs to use sccache2
Bug 1354048 - Update sccache version
(Assignee)

Comment 1

2 months ago
Created attachment 8859756 [details] [diff] [review]
Add sccache2 to releng.manifest [Checked in: Comment 3]
Attachment #8859756 - Flags: review?(ewong)

Comment 2

2 months ago
Comment on attachment 8859756 [details] [diff] [review]
Add sccache2 to releng.manifest [Checked in: Comment 3]

Review of attachment 8859756 [details] [diff] [review]:
-----------------------------------------------------------------

r=me w/ nits addressed.

::: suite/config/tooltool-manifests/linux32/releng.manifest
@@ +29,5 @@
> +"visibility": "public",
> +"filename": "sccache2.tar.xz",
> +"unpack": true,
> +"digest": "770bec21b71c386a5a89c9dede3b5dfbf47f7b22d395d5e4642d9c309a44fa05bf4a3a7b6d48b0bc737eafe3e3a8ce90005dcbad51a1aba4d326d5216b29dca1",
> +"size": 2173064

since the size, version and digest change more than the others, I'd like
to have the version, size and digest first, then the others.

Do note that this is only because of the visual changes are easier to track,
not because the order matters since it's a json dictionary.

Not sure why they changed the order there in browser, but it's a little more consistent throughout our manifests.

::: suite/config/tooltool-manifests/linux64/releng.manifest
@@ +34,2 @@
>  }
> +]

ditto here.

::: suite/config/tooltool-manifests/macosx64/releng.manifest
@@ +34,1 @@
>  }

here.

::: suite/config/tooltool-manifests/win32/releng.manifest
@@ +20,5 @@
> +"filename": "sccache2.tar.bz2",
> +"unpack": true,
> +"digest": "09c6b9407978a4ffa0638b412cde9517ebbdb9c8e8449f4dc6745f4da5c8025e29b4c99dfa1ddb84623d0dde8a3aac513f73e92fdb3a148e4c9a4e7931907964",
> +"size": 1628305
> +},

here

::: suite/config/tooltool-manifests/win64/releng.manifest
@@ +21,5 @@
> +"filename": "sccache2.tar.bz2",
> +"unpack": true,
> +"digest": "09c6b9407978a4ffa0638b412cde9517ebbdb9c8e8449f4dc6745f4da5c8025e29b4c99dfa1ddb84623d0dde8a3aac513f73e92fdb3a148e4c9a4e7931907964",
> +"size": 1628305
> +},

here.
Attachment #8859756 - Flags: review?(ewong) → review+
(Assignee)

Updated

2 months ago
status-seamonkey2.52: --- → fixed
Target Milestone: --- → seamonkey2.52
(Assignee)

Comment 3

2 months ago
Comment on attachment 8859756 [details] [diff] [review]
Add sccache2 to releng.manifest [Checked in: Comment 3]

https://hg.mozilla.org/comm-central/rev/5a335d7a01c1
Attachment #8859756 - Attachment description: Add sccache2 to releng.manifest → Add sccache2 to releng.manifest [Checked in: Comment 3]
(Assignee)

Updated

2 months ago
Status: ASSIGNED → RESOLVED
Last Resolved: 2 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.