Closed
Bug 1357936
Opened 3 years ago
Closed 3 years ago
Don't leak ProfilerIOInterposeObserver
Categories
(Core :: Gecko Profiler, enhancement)
Core
Gecko Profiler
Not set
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: njn, Assigned: njn)
Details
Attachments
(1 file)
4.35 KB,
patch
|
mstange
:
review+
|
Details | Diff | Splinter Review |
The patch adds a missing |delete|. (This leak only occurred when the "mainthreadio" feature was enabled, which is not the default.) The patch also makes the unregistering of the interpose observer conditional on there being one in the first place, avoiding a harmless but useless unregistering of |nullptr|.
![]() |
Assignee | |
Comment 1•3 years ago
|
||
Attachment #8859784 -
Flags: review?(mstange)
Updated•3 years ago
|
Attachment #8859784 -
Flags: review?(mstange) → review+
![]() |
Assignee | |
Comment 2•3 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/1b37b1ed3bc1013a5b8e1f062ceeb3b0f4dd0182 Bug 1357936 - Don't leak ProfilerIOInterposeObserver. r=mstange.
Comment 3•3 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/1b37b1ed3bc1
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•