Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Don't leak ProfilerIOInterposeObserver

RESOLVED FIXED in Firefox 55

Status

()

Product:
Core
Component:
Gecko Profiler
RESOLVED FIXED
Reported:
3 months ago
Modified:
3 months ago

People

(Reporter: njn, Assigned: njn)

Tracking

Version:
unspecified
Target:
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

Don't leak ProfilerIOInterposeObserver
4.35 KB, patch
mstange
: review+
Details | Diff | Splinter Review
(Assignee)

Description

•
3 months ago 
The patch adds a missing |delete|. (This leak only occurred when the
"mainthreadio" feature was enabled, which is not the default.)

The patch also makes the unregistering of the interpose observer conditional on
there being one in the first place, avoiding a harmless but useless
unregistering of |nullptr|.
(Assignee)

Comment 1

•
3 months ago 
Created attachment 8859784 [details] [diff] [review]
Don't leak ProfilerIOInterposeObserver
Attachment #8859784 - Flags: review?(mstange)
Attachment #8859784 - Flags: review?(mstange) → review+
 (Assignee)

Comment 2

•
3 months ago 
https://hg.mozilla.org/integration/mozilla-inbound/rev/1b37b1ed3bc1013a5b8e1f062ceeb3b0f4dd0182
Bug 1357936 - Don't leak ProfilerIOInterposeObserver. r=mstange.

Comment 3

•
3 months ago
bugherder 
https://hg.mozilla.org/mozilla-central/rev/1b37b1ed3bc1
Status: ASSIGNED → RESOLVED
Last Resolved: 3 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.