1357947 - In Product Links For XP EOL That Were Changed To Support Lithium Need To Be Reverted

Status: RESOLVED FIXED

(Release Engineering :: Release Requests, enhancement)

Description

[Ben (:bensternthal)]

Links that reference an XP-EOL article look to have been changed to support the manual redirect fix from lithium.

Example:

http://support.mozilla.org/xp-eol-ach

Note the locale code at the end.

Since we rolled back, these will not work.

I can not find the implementation bug however I was forwarded an email that contains discussion from March 7th. 

I can also confirm that we are seeing 404s from urls that look like 

"en-US/xp-eol-en-US"

Comment 1

[Ben (:bensternthal)]

Joni - can you note here what the exact Kitsune page is that these should go to (I do not want to guess).

Comment 2

[Chris Peterson [:cpeterson]]

Peter, is the following correct? Did we have any in-product URLs for the XP EOL SUMO page?

I don't think the XP EOL URLs are in-product. AFAIK, these URLs were just pushed to XP/Vista users using the "whatsnew" page (WNP) when we migrated those users to ESR 52.

Below is a list of the XP EOL URLs that we used for the manual redirects to Lithium when 52 was released. I was clicking the first link in this spreadsheet to test the redirects today, which is probably why you see "http://support.mozilla.org/xp-eol-ach" in the server logs. :)

https://docs.google.com/spreadsheets/d/1zWydjUHAiHLQmL9H2eknaopnOcKlqMNxvjdRh6Ye3fk/

Comment 3

[Ben (:bensternthal)]

OK I may have been wrong about in-product (good), i was doing a bit of spelunking and it's been a long day :)

If these are on the whatsnew page, am I correct these links are in bedrock/moz.org

Basically let me know where they live and I can chase down getting them fixed.

Comment 4

[Chris Peterson [:cpeterson]]

(In reply to Ben (:bensternthal) from comment #3)
> If these are on the whatsnew page, am I correct these links are in
> bedrock/moz.org
> 
> Basically let me know where they live and I can chase down getting them
> fixed.

Rail, I think you pushed the whatsnew page to XP/Vista users when we migrated them to ESR 52. That was bug 1315153. Where does whatsnew store these URLs for the XP EOL SUMO pages? We plan to push the same pages to XP/Vista users again in 2018 Q1 to warn them when ESR 52 support for XP/Vista is ending. That is bug 1319162.

Comment 5

[Johan Lorenzo [:jlorenzo]]

(In reply to Chris Peterson [:cpeterson] from comment #4)
> Where does whatsnew store these URLs for the XP EOL SUMO pages?

The URL is defined on the update server (aka Balrog). It's part of XML given by [1]. I left more information in bug 1358065. 

[1] For instance Mac OS X 10.6 desupport: https://aus5.mozilla.org/update/6/Firefox/48.0.2/20160823121617/Darwin_x86_64-gcc3-u-i386-x86_64/en-US/release/Darwin%2010/SSE3/default/default/update.xml?force=1

Comment 6

[Johan Lorenzo [:jlorenzo]]

My bad, I was off topic. We actually need to change the release blobs of:
* https://aus4-admin.mozilla.org/rules/519
* https://aus4-admin.mozilla.org/rules/527

I'm going to change it.

Comment 7

[Johan Lorenzo [:jlorenzo]]

Like :cpeterson referenced in bug 1315153 comment 29, the URL needs to be: https://support.mozilla.org/1/firefox/%VERSION%/%OS%/%LOCALE%/xp-eol

Before I acted on these rules, [1] returned:

> <updates>
>   <update
>     type="minor"
>     displayVersion="52.0.2esr"
>     appVersion="52.0.2"
>     platformVersion="52.0.2"
>     buildID="20170323110425"
>     detailsURL="https://www.mozilla.org/en-US/firefox/52.0.2/releasenotes/"
>     actions="showURL"
>     openURL="https://support.mozilla.org/xp-eol-en-US">
>     <patch
>       type="complete"
>       URL="http://download.mozilla.org/?product=firefox-52.0.2esr-complete&os=win&lang=en-US&force=1"
>       hashFunction="sha512"
>       hashValue="ababb8d102f0c51b499e7b9aed6daf0993d4053c440c7cd86a8160c7ccbb01c765989a98cca77ef1d63d0203e99eaa667f5fb63b38cccec2b8902b81e8cb04e8"
>       size="54347094"/>
>     </update>
> </updates>

(Note: openURL="https://support.mozilla.org/xp-eol-en-US")

I changed [2] and [3] to contain:
>   "openURL": "https://support.mozilla.org/1/firefox/52.0.1esr/win/%LOCALE%/xp-eol",

Now, we're returning:

> <updates>
>   <update
>     type="minor"
>     displayVersion="52.0.2esr"
>     appVersion="52.0.2"
>     platformVersion="52.0.2"
>     buildID="20170323110425"
>     detailsURL="https://www.mozilla.org/en-US/firefox/52.0.2/releasenotes/"
>     actions="showURL"
>     openURL="https://support.mozilla.org/1/firefox/52.0.2esr/win/en-US/xp-eol">
>     <patch
>       type="complete"
>       URL="http://download.mozilla.org/?product=firefox-52.0.2esr-complete&os=win&lang=en-US&force=1"
>       hashFunction="sha512"
>       hashValue="ababb8d102f0c51b499e7b9aed6daf0993d4053c440c7cd86a8160c7ccbb01c765989a98cca77ef1d63d0203e99eaa667f5fb63b38cccec2b8902b81e8cb04e8"
>       size="54347094"/>
>   </update>
> </updates>

[1] https://aus5.mozilla.org/update/6/Firefox/50.0.2/20161129173726/WINNT_x86-msvc/en-US/esr/Windows_NT%206.0.0.0%20(x64)(noBug1296630v1)/SSE3/default/default/update.xml?force=1
[2] https://aus4-admin.mozilla.org/releases#Firefox-52.0.2esr-build1-WNP
[3] https://aus4-admin.mozilla.org/releases#Firefox-52.0.1esr-build2-WNP

Comment 8

[Julien Cristau [:jcristau]]

Moving to release automation since this isn't actually in-product.

Comment 9

[Ben (:bensternthal)]

Thanks for the quick work and help in understanding this.

Please make sure to resolve this bug when these changes are live. The url https://support.mozilla.org/1/firefox/52.0.2esr/win/en-US/xp-eol is tested and works :)

Thanks again.

Comment 10

[Chris Peterson [:cpeterson]]

I tested a few localized XP EOL URLs and they work for me. Thanks!

Comment 11

[Rail Aliiev [:rail]]

Thank you Johan!