Permaorange in test_smilWithTransition.html when Gecko 55 merges to beta on 2017-06-12

RESOLVED FIXED in Firefox 55

Status

()

Core
CSS Parsing and Computation
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: philor, Assigned: mantaroh)

Tracking

55 Branch
mozilla55
Points:
---

Firefox Tracking Flags

(firefox-esr45 unaffected, firefox-esr52 unaffected, firefox53 unaffected, firefox54 unaffected, firefox55+ fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

a year ago
I'm guessing (wildly) that dom.animations-api.core.enabled is the false-by-default-on-beta pref that you need to be setting to avoid https://treeherder.mozilla.org/logviewer.html#?job_id=92721338&repo=try&lineNumber=7776 (should be able to repro that locally by just changing /config/milestone.txt from 55a1 to 55). 


[Tracking Requested - why for this release]:

Merge bustage, closed tree, delayed b1, wailing and gnashing of teeth.
(Reporter)

Updated

a year ago
Flags: needinfo?(bbirtles)
This should not use getAnimations() without setting the appropriate pref (which will mean splitting this into file_* and test_*)
Assignee: nobody → mantaroh
Status: NEW → ASSIGNED
Flags: needinfo?(bbirtles) → needinfo?(mantaroh)
(Assignee)

Comment 2

a year ago
Thanks, Brian.

(In reply to Brian Birtles (:birtles) from comment #1)
> This should not use getAnimations() without setting the appropriate pref
> (which will mean splitting this into file_* and test_*)

I separated this tests and add pref. I confirmed using by '--setpref dom.animations-api.core.enabled=false ' options on my local build.
Try :
 https://treeherder.mozilla.org/#/jobs?repo=try&revision=a41b45545291aee04bc1ad5b8e849549f56da71d
Flags: needinfo?(mantaroh)
You can test on try by modifying all.js (or you could try modifying /config/milestone.txt as philor suggested in comment 0). You can push a patch with that change to try to check. Daisuke had the same question so please check with him.
Tracking 55+ for this permaorange, especially to avoid delays in B1.
tracking-firefox55: ? → +
(Assignee)

Comment 5

a year ago
(In reply to Brian Birtles (:birtles) from comment #3)
> You can test on try by modifying all.js (or you could try modifying
> /config/milestone.txt as philor suggested in comment 0). You can push a
> patch with that change to try to check. Daisuke had the same question so
> please check with him.

Thanks.
I try it: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7d4d8428c1048fa4281b278f2de13bca11b97cee
(Assignee)

Comment 6

a year ago
(In reply to Mantaroh Yoshinaga[:mantaroh] from comment #5)
> (In reply to Brian Birtles (:birtles) from comment #3)
> > You can test on try by modifying all.js (or you could try modifying
> > /config/milestone.txt as philor suggested in comment 0). You can push a
> > patch with that change to try to check. Daisuke had the same question so
> > please check with him.
> 
> Thanks.
> I try it:
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=7d4d8428c1048fa4281b278f2de13bca11b97cee

Ah, I forgot adding test file.
Retry it: https://treeherder.mozilla.org/#/jobs?repo=try&revision=61af642f9900cc0fa1e3fd68e1a79b68d1f9a8a3
Comment hidden (mozreview-request)
(Assignee)

Comment 8

a year ago
Comment on attachment 8861814 [details]
Bug 1357979 - Add dom.animations-api.core.enabled preference to test of smil with transition in order to enable beta/release test.

As result of talking with Brian, We had better to use 'hg clone' instead creating the file_smilWithTransition.html. So I'll rewrite the patch.
Attachment #8861814 - Flags: review?(bbirtles)
(In reply to Mantaroh Yoshinaga[:mantaroh] from comment #8)
> Comment on attachment 8861814 [details]
> Bug 1357979 - Add dom.animations-api.core.enabled preference to test of smil
> with transition in order to enable beta/release test.
> 
> As result of talking with Brian, We had better to use 'hg clone' instead
> creating the file_smilWithTransition.html. So I'll rewrite the patch.

Alternatively (and perhaps better, assuming it works), you could do:

1. hg mv test_smilWithTransition.html file_smilWithTransition.html
2. Create a new test_smilWithTransition.html
3. hg add test_smilWithTransition.html
Comment hidden (mozreview-request)

Comment 11

a year ago
mozreview-review
Comment on attachment 8861814 [details]
Bug 1357979 - Add dom.animations-api.core.enabled preference to test of smil with transition in order to enable beta/release test.

https://reviewboard.mozilla.org/r/132286/#review137500

::: dom/smil/test/file_smilWithTransition.html:21
(Diff revision 2)
> -  SimpleTest.waitForExplicitFinish();
> +  // Bring SimpleTest's function from opener.
> +  if (opener) {
> +    window['finish'] = opener.SimpleTest.finish.bind(opener);
> +    window['ok']     = opener.SimpleTest.ok.bind(opener);
> +    window['is']     = opener.SimpleTest.is.bind(opener);
> +    window['finishAndClose'] = function() {
> +      finish();
> +      self.close()
> +    };
> +  }

Nit: In other tests we just write this as:

  var is = opener.is.bind(opener);
  var ok = opener.ok.bind(opener);
  function finish() {
    var o = opener;
    self.close();
    o.SimpleTest.finish();
  }

That might be a little simpler?

(Of course, you'll need to update the call to finishAndClose() to just finish() if you do that.)
Attachment #8861814 - Flags: review?(bbirtles) → review+
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Comment 14

a year ago
(In reply to Mantaroh Yoshinaga[:mantaroh] from comment #13)
> Comment on attachment 8861814 [details]
> Bug 1357979 - Add dom.animations-api.core.enabled preference to test of smil
> with transition in order to enable beta/release test.
> 
> Review request updated; see interdiff:
> https://reviewboard.mozilla.org/r/132286/diff/3-4/

Previous patch is wrong. I fixed it.
try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ff6485949f615536bf6ec53707579a7bd3ace414

Comment 15

a year ago
Pushed by mantaroh@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/e1428fe19c8b
Add dom.animations-api.core.enabled preference to test of smil with transition in order to enable beta/release test. r=birtles

Comment 16

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/e1428fe19c8b
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox55: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.