Use helper functions of TimeUnit to make code more readable

RESOLVED FIXED in Firefox 55

Status

()

Core
Audio/Video: Playback
P3
normal
RESOLVED FIXED
a month ago
a month ago

People

(Reporter: jwwang, Assigned: jwwang)

Tracking

(Blocks: 1 bug)

unspecified
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

a month ago
1. TimeUnit::Zero() is more readable than TimeUnit::FromMicroseconds(0).
2. TimeUnit::Zero() is more readable than TimeUnit().
3. TimeUnit::FromInfinity() is more readable than TimeUnit::FromMicroseconds(std::numeric_limits<int64_t>::max()).
4. t.IsPositive() is more readable than t > TimeUnit().
(Assignee)

Updated

a month ago
Assignee: nobody → jwwang
Blocks: 1245019
Priority: -- → P3
(Assignee)

Updated

a month ago
Depends on: 1357987
Comment hidden (mozreview-request)
(Assignee)

Updated

a month ago
Attachment #8860247 - Flags: review?(kaku)

Comment 2

a month ago
mozreview-review
Comment on attachment 8860247 [details]
Bug 1357986 - Use helper functions of TimeUnit to make code more readable.

https://reviewboard.mozilla.org/r/132250/#review135112
Attachment #8860247 - Flags: review?(kaku) → review+
(Assignee)

Comment 3

a month ago
Thanks!

Comment 4

a month ago
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e535df594d22
Use helper functions of TimeUnit to make code more readable. r=kaku

Comment 5

a month ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/e535df594d22
Status: NEW → RESOLVED
Last Resolved: a month ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
(Assignee)

Updated

a month ago
No longer depends on: 1357987
You need to log in before you can comment on or make changes to this bug.