1357986 - Use helper functions of TimeUnit to make code more readable

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P3)

Description

[JW Wang [:jwwang] [:jw_wang]]

1. TimeUnit::Zero() is more readable than TimeUnit::FromMicroseconds(0).
2. TimeUnit::Zero() is more readable than TimeUnit().
3. TimeUnit::FromInfinity() is more readable than TimeUnit::FromMicroseconds(std::numeric_limits<int64_t>::max()).
4. t.IsPositive() is more readable than t > TimeUnit().

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1357986 - Use helper functions of TimeUnit to make code more readable.

1. using media::TimeUnit to save some typing.
2. replace TimeUnit() with TimeUnit::Zero().
3. replace TimeUnit::FromXXX(0) with TimeUnit::Zero().
4. replace TimeUnit::FromMicroseconds(std::numeric_limits<int64_t>::max()) with TimeUnit::FromInfinity().
5. replace some uses of int64_t with TimeUnit.
6. replace t > TimeUnit() with t.IsPositive().

Review commit: https://reviewboard.mozilla.org/r/132250/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/132250/

Comment 2

[Tzuhao Kuo [:kaku]]

Comment on attachment 8860247 [details]
Bug 1357986 - Use helper functions of TimeUnit to make code more readable.

https://reviewboard.mozilla.org/r/132250/#review135112

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e535df594d22
Use helper functions of TimeUnit to make code more readable. r=kaku

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e535df594d22