dom/media relies on ipc/chromium namespace pollution

RESOLVED FIXED in Firefox 55

Status

()

Core
Audio/Video: Playback
RESOLVED FIXED
a month ago
a month ago

People

(Reporter: Jan Beich (away from May 25 to June 11), Unassigned)

Tracking

(Blocks: 1 bug)

Trunk
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

- OS_* are defined by ipc/chromium/chromium-config.mozbuild, if the pref moves this will break
- other code already uses MOZ_WIDGET_* or XP_*
- diverging from Linux parity on Tier3 platforms can increase bug triaging cost e.g., bug 1341108
Comment hidden (mozreview-request)
FYI: media.rust.mp4parser=true works fine on FreeBSD 12 amd64.
Thanks for the correction!

Comment 4

a month ago
mozreview-review
Comment on attachment 8859835 [details]
Bug 1357988 - Don't use IPC macros for media pref defaults.

https://reviewboard.mozilla.org/r/131824/#review134686
Attachment #8859835 - Flags: review?(ayang) → review+
Keywords: checkin-needed

Comment 5

a month ago
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e6cd1cb7eaa9
Don't use IPC macros for media pref defaults. r=alfredo
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/e6cd1cb7eaa9
Status: NEW → RESOLVED
Last Resolved: a month ago
status-firefox55: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.