Closed Bug 1358030 Opened 3 years ago Closed 3 years ago

[Firefox for Android] add mochitest to test remote h/w encoder

Categories

(Core :: WebRTC: Audio/Video, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: mchiang, Assigned: mchiang)

References

Details

Attachments

(1 file)

No description provided.
Assignee: nobody → mchiang
Note that the autophone specific manifests are being removed in bug 1352333.
See Also: → 1352333
Comment on attachment 8859974 [details]
Bug 1358030 - add mochitest for webrtc android remote h/w encoder.

https://reviewboard.mozilla.org/r/132018/#review135790

Lgtm.

::: dom/media/tests/mochitest/test_peerConnection_basicVideoRemoteHwEncoder.html:17
(Diff revision 1)
> +  });
> +
> +  runNetworkTest(options => {
> +    SpecialPowers.pushPrefEnv(
> +      {
> +        'set': [

Nit: No quotes around property names

https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style#JavaScript_objects

::: dom/media/tests/mochitest/test_peerConnection_basicVideoRemoteHwEncoder.html:21
(Diff revision 1)
> +      }, function (options) {
> +        options = options || { };

Nit: I know this is copied from elsewhere, but we can use defaults now:

    }, function(options = {}) {
        var test = new PeerConnectionTest(options);
Attachment #8859974 - Flags: review?(jib) → review+
Rank: 18
Priority: -- → P1
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/378e200f70a3
add mochitest for webrtc android remote h/w encoder. r=jib
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/378e200f70a3
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Attachment #8859974 - Flags: review?(jolin)
You need to log in before you can comment on or make changes to this bug.