1358030 - [Firefox for Android] add mochitest to test remote h/w encoder

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, enhancement, P1)

Comment 1

[Munro Mengjue Chiang [:mchiang] Be Mozillian since 1/19/2018]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4782b8430403315ba57210778c6cc35c34a08d3b

Comment 2

[Munro Mengjue Chiang [:mchiang] Be Mozillian since 1/19/2018]

Attachment: Bug 1358030 - add mochitest for webrtc android remote h/w encoder.

Review commit: https://reviewboard.mozilla.org/r/132018/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/132018/

Comment 3

[Bob Clary [:bc:]]

Note that the autophone specific manifests are being removed in bug 1352333.

Comment 4

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Comment on attachment 8859974 [details]
Bug 1358030 - add mochitest for webrtc android remote h/w encoder.

https://reviewboard.mozilla.org/r/132018/#review135790

Lgtm.

::: dom/media/tests/mochitest/test_peerConnection_basicVideoRemoteHwEncoder.html:17
(Diff revision 1)
> +  });
> +
> +  runNetworkTest(options => {
> +    SpecialPowers.pushPrefEnv(
> +      {
> +        'set': [

Nit: No quotes around property names

https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style#JavaScript_objects

::: dom/media/tests/mochitest/test_peerConnection_basicVideoRemoteHwEncoder.html:21
(Diff revision 1)
> +      }, function (options) {
> +        options = options || { };

Nit: I know this is copied from elsewhere, but we can use defaults now:

    }, function(options = {}) {
        var test = new PeerConnectionTest(options);

Comment 5

[Munro Mengjue Chiang [:mchiang] Be Mozillian since 1/19/2018]

Comment on attachment 8859974 [details]
Bug 1358030 - add mochitest for webrtc android remote h/w encoder.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/132018/diff/1-2/

Comment 6

[Munro Mengjue Chiang [:mchiang] Be Mozillian since 1/19/2018]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2feaad3c1257501e533b0ee213592396fe895d6d

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/378e200f70a3
add mochitest for webrtc android remote h/w encoder. r=jib

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/378e200f70a3