Closed
Bug 1358030
Opened 5 years ago
Closed 5 years ago
[Firefox for Android] add mochitest to test remote h/w encoder
Categories
(Core :: WebRTC: Audio/Video, enhancement, P1)
Core
WebRTC: Audio/Video
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: mchiang, Assigned: mchiang)
References
Details
Attachments
(1 file)
No description provided.
Assignee | ||
Comment 1•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4782b8430403315ba57210778c6cc35c34a08d3b
Comment hidden (mozreview-request) |
Assignee | ||
Updated•5 years ago
|
Assignee: nobody → mchiang
Comment 3•5 years ago
|
||
Note that the autophone specific manifests are being removed in bug 1352333.
See Also: → 1352333
Comment 4•5 years ago
|
||
mozreview-review |
Comment on attachment 8859974 [details] Bug 1358030 - add mochitest for webrtc android remote h/w encoder. https://reviewboard.mozilla.org/r/132018/#review135790 Lgtm. ::: dom/media/tests/mochitest/test_peerConnection_basicVideoRemoteHwEncoder.html:17 (Diff revision 1) > + }); > + > + runNetworkTest(options => { > + SpecialPowers.pushPrefEnv( > + { > + 'set': [ Nit: No quotes around property names https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style#JavaScript_objects ::: dom/media/tests/mochitest/test_peerConnection_basicVideoRemoteHwEncoder.html:21 (Diff revision 1) > + }, function (options) { > + options = options || { }; Nit: I know this is copied from elsewhere, but we can use defaults now: }, function(options = {}) { var test = new PeerConnectionTest(options);
Attachment #8859974 -
Flags: review?(jib) → review+
Updated•5 years ago
|
Rank: 18
Priority: -- → P1
Comment hidden (mozreview-request) |
Assignee | ||
Comment 6•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2feaad3c1257501e533b0ee213592396fe895d6d
Assignee | ||
Updated•5 years ago
|
Keywords: checkin-needed
Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/378e200f70a3 add mochitest for webrtc android remote h/w encoder. r=jib
Keywords: checkin-needed
Comment 8•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/378e200f70a3
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Updated•5 years ago
|
Attachment #8859974 -
Flags: review?(jolin)
You need to log in
before you can comment on or make changes to this bug.
Description
•