Closed
Bug 1358045
Opened 9 years ago
Closed 3 years ago
Fix -Wunused-function warning-as-error in js/src/wasm/WasmSignalHandlers.cpp
Categories
(Core :: JavaScript Engine: JIT, defect, P3)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
WORKSFORME
| Tracking | Status | |
|---|---|---|
| firefox53 | --- | unaffected |
| firefox54 | --- | unaffected |
| firefox55 | --- | affected |
| firefox110 | --- | verified |
People
(Reporter: cpeterson, Assigned: cpeterson)
References
Details
(Keywords: triage-deferred)
Attachments
(1 file)
|
59 bytes,
text/x-review-board-request
|
Details |
This warning is a regression from bug 1338217 and breaks the SpiderMonkey ARM Simulator debug builds on OS X.
js/src/wasm/WasmSignalHandlers.cpp:374:1: warning: unused function 'ContextToFP' [-Wunused-function]
Here is a green Try build:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=41eeb96f82d45480db3fdadb940c94b8a831d9d3
| Comment hidden (mozreview-request) |
|
||
Comment 2•9 years ago
|
||
| mozreview-review | ||
Comment on attachment 8859912 [details]
Bug 1358045 - Fix -Wunused-function warning in js/src/wasm/WasmSignalHandlers.cpp.
https://reviewboard.mozilla.org/r/131972/#review134744
I see the warning but this patch does nothing to fix it, from what I can tell: with the patch applied the warning is still there. Wrong patch?
Attachment #8859912 -
Flags: review?(lhansen)
|
||
Updated•8 years ago
|
Keywords: triage-deferred
Priority: -- → P3
|
||
Updated•3 years ago
|
Severity: normal → S3
|
Assignee | |
Comment 3•3 years ago
|
||
This -Wunused-function warning is no longer reported.
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox110:
--- → verified
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•