Closed Bug 1358047 Opened 3 years ago Closed 3 years ago

Move Baseline CacheIR stubcode map from JitCompartment to JitZone

Categories

(Core :: JavaScript Engine: JIT, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: jandem, Assigned: jandem)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [qf])

Attachments

(1 file)

Attached patch PatchSplinter Review
We don't have any CacheIR instructions that bake in compartment/global specific stuff in Baseline, so we should just share CacheIR stub code across compartments within a zone.

I also did some small cleanups, we now store the map directly instead of a pointer to it and I added "Baseline" in a few places to make it clear it's baseline-specific.

We could do the same for the remaining non-CacheIR stubs, but auditing them is harder and I think we should just convert most of them.
Attachment #8859918 - Flags: review?(evilpies)
Blocks: 1351769
Whiteboard: [qf]
Comment on attachment 8859918 [details] [diff] [review]
Patch

Review of attachment 8859918 [details] [diff] [review]:
-----------------------------------------------------------------

Hey Jan.  I can r? this if you want.  (just did actually, pretty straightforward patch).  Looks awesome.  I can steal the r? from :evilpie if he's ok with it.
Attachment #8859918 - Flags: review?(evilpies) → review+
Pushed by jandemooij@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ccdbdd6e79e3
Move Baseline CacheIR code map from JitCompartment to JitZone. r=djvj
https://hg.mozilla.org/mozilla-central/rev/ccdbdd6e79e3
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.