1358054 - [Performance] combine double updateRequest call while receive event in _onNetworkEventUpdate

Status: NEW

(DevTools :: Netmonitor, enhancement, P3)

Description

[[e-mail]]

in _onNetworkEventUpdate there are 3 cases that we called updateRequest twice. They are

* _onSecurityInfo
* _onResponseContent
* _onEventTimings

http://searchfox.org/mozilla-central/source/devtools/client/netmonitor/src/netmonitor-controller.js#607

onResponseContent is handled in Bug 1356957, we can combine the rest double updateRequest call while receive events

Comment 2

[Ricky Chien [:rickychien] (inactive)]

React has implemented its batched update mechanism when seeing frequent props update in a short time. I suspect that influence of this patch would be minor.

Fred,

Beside fixing test failures, if you still think that it's worth to land this patch, could you verify how many times subscribe listener calls decrease after applying your patch?

(Every subscribe listener calls imply one react components update)

Add a console.log in index.js (launchpad) or index.html (toolbox) to see

let count = 0;
store.subscribe(() => {
  console.log(count++);
});

Comment 3

[[e-mail]]

Thanks for the suggestion.

After apply the patch, it reduced state update from 105 -> 102 for 144 requests from bbc.com , so it might not worth to fix this at this time

Comment 4

[[e-mail]]

Attachment: Bug 1358054 - combine double updateRequest call while receive event in _onNetworkEventUpdate;

Review commit: https://reviewboard.mozilla.org/r/133710/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/133710/

Comment 5

[[e-mail]]

attach WIP patch in case someone want to pick it and fix the test

Comment 6

[David Lawrence [:dkl]]

Changing qe-verify? to qe-verify+.