1358061 - Remove moz-audiochannel related code for HTMLMediaElement

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P3)

Description

[Alastor Wu [:alwu]]

The "moz-audiochannel" is used for b2g-only.

Comment 1

[Alastor Wu [:alwu]]

Attachment: Bug 1358061 - remove moz-audiochannel codes for media element and web audio.

Review commit: https://reviewboard.mozilla.org/r/132278/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/132278/

Comment 2

[Alastor Wu [:alwu]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fa1009ef964fc03155284f68aee5cbd3e1e7ad2d

Comment 3

[Alastor Wu [:alwu]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3f04df2f951f4dffddde15334ab79497c9c574f0&selectedJob=93216466

Comment 4

[Andrea Marchesini [:baku]]

Comment on attachment 8860262 [details]
Bug 1358061 - remove moz-audiochannel codes for media element and web audio.

https://reviewboard.mozilla.org/r/132278/#review135676

You must remove mozaudiochannel from nsGkAtomList.h as well.
A similar patch must be written for WebAudio.
We also need to remove code in BrowserElement, right?

Comment 5

[Alastor Wu [:alwu]]

(In reply to Andrea Marchesini [:baku] from comment #4)
> You must remove mozaudiochannel from nsGkAtomList.h as well.
> A similar patch must be written for WebAudio.

OK.

> We also need to remove code in BrowserElement, right?

Yes, I'll file another bug to remove them, that needs some extra works because we need to modify some tests which uses "onactivestatechanged" to test something.

This bug is filed due to we don't want to block the progress of the bug1357645. (see bug1299390 comment1)

Comment 6

[Alastor Wu [:alwu]]

Comment on attachment 8860262 [details]
Bug 1358061 - remove moz-audiochannel codes for media element and web audio.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/132278/diff/1-2/

Comment 7

[Alastor Wu [:alwu]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=213809bab66fd2107653a3df5c0899dcd4066d8f

Comment 8

[Alastor Wu [:alwu]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9f066a721463360877332a4ea1b0d3f2c47d7bb4

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6e7efb9115fd
remove moz-audiochannel codes for media element and web audio. r=baku

Comment 10

[Phil Ringnalda (:philor)]

Backed out in https://hg.mozilla.org/integration/autoland/rev/9fbadd5bacea for https://treeherder.mozilla.org/logviewer.html#?job_id=94383351&repo=autoland

Comment 11

[Alastor Wu [:alwu]]

(In reply to Phil Ringnalda (:philor) from comment #10)
> Backed out in https://hg.mozilla.org/integration/autoland/rev/9fbadd5bacea
> for
> https://treeherder.mozilla.org/logviewer.html#?job_id=94383351&repo=autoland

Ah, sorry,
I forgot to update to the latest patch.

Comment 12

[Alastor Wu [:alwu]]

Comment on attachment 8860262 [details]
Bug 1358061 - remove moz-audiochannel codes for media element and web audio.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/132278/diff/2-3/

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b19e0113456d
remove moz-audiochannel codes for media element and web audio. r=baku

Comment 14

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b19e0113456d

Comment 15

[Eric Shepherd [:sheppy]]

The removal of this from Web Audio and HTMLMediaElement is now documented:

https://developer.mozilla.org/en-US/docs/Web/API/AudioContext
https://developer.mozilla.org/en-US/docs/Web/API/HTMLMediaElement
https://developer.mozilla.org/en-US/Firefox/Releases/55