Remove moz-audiochannel related code for HTMLMediaElement

RESOLVED FIXED in Firefox 55

Status

()

P3
normal
RESOLVED FIXED
2 years ago
a year ago

People

(Reporter: alwu, Assigned: alwu)

Tracking

({dev-doc-complete})

Other Branch
mozilla55
dev-doc-complete
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
The "moz-audiochannel" is used for b2g-only.
Priority: -- → P3
Comment hidden (mozreview-request)
(Assignee)

Updated

2 years ago
Attachment #8860262 - Flags: review?(amarchesini)

Comment 4

2 years ago
mozreview-review
Comment on attachment 8860262 [details]
Bug 1358061 - remove moz-audiochannel codes for media element and web audio.

https://reviewboard.mozilla.org/r/132278/#review135676

You must remove mozaudiochannel from nsGkAtomList.h as well.
A similar patch must be written for WebAudio.
We also need to remove code in BrowserElement, right?
Attachment #8860262 - Flags: review?(amarchesini) → review+
(Assignee)

Comment 5

2 years ago
(In reply to Andrea Marchesini [:baku] from comment #4)
> You must remove mozaudiochannel from nsGkAtomList.h as well.
> A similar patch must be written for WebAudio.

OK.

> We also need to remove code in BrowserElement, right?

Yes, I'll file another bug to remove them, that needs some extra works because we need to modify some tests which uses "onactivestatechanged" to test something.

This bug is filed due to we don't want to block the progress of the bug1357645. (see bug1299390 comment1)
Comment hidden (mozreview-request)

Comment 9

2 years ago
Pushed by alwu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6e7efb9115fd
remove moz-audiochannel codes for media element and web audio. r=baku
(Assignee)

Comment 11

2 years ago
(In reply to Phil Ringnalda (:philor) from comment #10)
> Backed out in https://hg.mozilla.org/integration/autoland/rev/9fbadd5bacea
> for
> https://treeherder.mozilla.org/logviewer.html#?job_id=94383351&repo=autoland

Ah, sorry,
I forgot to update to the latest patch.
Comment hidden (mozreview-request)

Comment 13

2 years ago
Pushed by alwu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b19e0113456d
remove moz-audiochannel codes for media element and web audio. r=baku

Comment 14

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/b19e0113456d
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Keywords: dev-doc-needed
You need to log in before you can comment on or make changes to this bug.