1358062 - Add core ping to WebAppActivity and CustomTabActivity

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Metrics, enhancement, P5)

Description

[Nevin Chen(Not active on Bugzilla)]

Since now only BrowserApp has TelemetryCorePingDelegate on it, we should do the same for PWA and Custom Tab.

Comment 1

[Nevin Chen(Not active on Bugzilla)]

Attachment: Bug 1358062 - WIP

Review commit: https://reviewboard.mozilla.org/r/134640/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/134640/

Comment 2

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

It looks like blocking both PWA and custom tab, right?

Comment 3

[Nevin Chen(Not active on Bugzilla)]

I'm busy right now so anyone can take itl

Adding the core ping will make the DAU more accurate if the data come from telemetry_core_parguet. But we can come out with the number where somewhere else like android_clients.

I may have time next two week but it'll be almost near the code free day (June 5)

Comment 4

[Nevin Chen(Not active on Bugzilla)]

Hi Max, Sebastian

CustomTabActivity is not extending GeckoApp in the future.
So it'll be meaningless to move CorePingDelegate to GeckoApp for it.

I'm suggesting move all the BrowserAppDelegate to another class (e.g. FennecLifecycleDelegator)
And hook the Application class using aplpication.registerActivityLifecycleCallbacks[1] method to hook all the Activity Lifecycle calls to it.

We can exclude some activities we don't want (e.g. LauncherActivity or GeckoPreferences) using instanceof in lifecycle callbacks.

How do you think?

[1] https://developer.android.com/reference/android/app/Application.ActivityLifecycleCallbacks.html

Comment 5

[Firefox Bug Husbandry Bot]

Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195

Needinfo :susheel if you think this bug should be re-triaged.

Comment 6

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.