PBE_CreateContext() and SEC_PKCS5GetIV() leak a slot reference

RESOLVED FIXED in 3.5

Status

NSS
Libraries
P1
normal
RESOLVED FIXED
16 years ago
16 years ago

People

(Reporter: Wan-Teh Chang, Assigned: Robert Relyea)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [adt2 RTM])

Attachments

(1 attachment)

(Reporter)

Description

16 years ago
PBE_CreateContext() and SEC_PKCS5GetIV() in pk11pbe.c call
PK11_GetInternalSlot() but do not free the slot reference.
(Reporter)

Comment 1

16 years ago
I just wanted to add that the slot is passed to PK11_RawPBEKeyGen()
to generate a symKey, which gets its own reference to the slot
(in PK11_CreateSymKey()).  So PBE_CreateContext() and SEC_PKCS5GetIV()
need to free their reference to the slot.
(Reporter)

Comment 2

16 years ago
Changed the QA contact to Bishakha.
QA Contact: sonja.mirtitsch → bishakhabanerjee
(Reporter)

Comment 3

16 years ago
Created attachment 82957 [details] [diff] [review]
Proposed patch

This patch is the obvious fix.	Bob, please review it.
(Reporter)

Comment 4

16 years ago
Assigned the bug to Bob.
Assignee: wtc → relyea
Priority: -- → P1
Target Milestone: --- → 3.5
(Assignee)

Comment 5

16 years ago
Comment on attachment 82957 [details] [diff] [review]
Proposed patch

Yup, this is the obvious patch.
Attachment #82957 - Flags: review+
(Reporter)

Comment 6

16 years ago
Patch checked into the tip of NSS.
Status: NEW → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
(Reporter)

Updated

16 years ago
Blocks: 145836

Comment 7

16 years ago
adt1.0.1+ (on ADT's behalf) for checkin to the 1.0 branch. Pls check this in
asap. thanks! 
Keywords: adt1.0.1+, mozilla1.0.1, nsbeta1+
Whiteboard: [adt2 RTM]
(Reporter)

Updated

16 years ago
Keywords: adt1.0.1+, mozilla1.0.1 → fixed1.0.1
You need to log in before you can comment on or make changes to this bug.