Closed
Bug 1358109
Opened 7 years ago
Closed 7 years ago
Use IPCBlob in PFilePicker
Categories
(Core :: DOM: Core & HTML, enhancement)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: baku, Assigned: baku)
References
Details
Attachments
(1 file)
|
6.22 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•7 years ago
|
||
Assignee: nobody → amarchesini
|
|
Assignee | |
Comment 2•7 years ago
|
||
This bug is part of the PBlob refactoring.
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8860003 -
Flags: review?(bugs)
|
||
Comment 3•7 years ago
|
||
Comment on attachment 8860003 [details] [diff] [review] ipcBlob_12_PFilePicker.patch > for (unsigned i = 0; i < aData.Length(); i++) { >+ IPCBlob ipcBlob; >+ > MOZ_ASSERT(aData[i].mType == BlobImplOrString::eBlobImpl); >- BlobParent* blobParent = parent->GetOrCreateActorForBlobImpl(aData[i].mBlobImpl); >- if (blobParent) { >- blobs.AppendElement(blobParent); >+ nsresult rv = IPCBlobUtils::Serialize(aData[i].mBlobImpl, parent, ipcBlob); >+ if (NS_WARN_IF(NS_FAILED(rv))) { >+ break; > } >+ >+ ipcBlobs.AppendElement(Move(ipcBlob)); Does IPCBlob have move ctor? Seems like not, so why use Move? It just makes one to think something is being moved here.
Attachment #8860003 -
Flags: review?(bugs) → review+
Pushed by amarchesini@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/dec83a85f824 Use IPCBlob in PFilePicker, r=smaug
|
||
Comment 5•7 years ago
|
||
Backed out bug 1358109, bug 1358111, bug 1358114 and bug 1358113 in addition to bug 1358115 earlier for failing mochitest dom/indexedDB/test/test_blob_worker_xhr_read_slice.html: Bug 1358109 https://hg.mozilla.org/integration/mozilla-inbound/rev/d8868683036b331ec66764056fad6ca8234427a6 Bug 1358111 https://hg.mozilla.org/integration/mozilla-inbound/rev/9f488fa8dae133819c3b26a7ffee8758962e16bf https://hg.mozilla.org/integration/mozilla-inbound/rev/459116dcf7987f6b9d4dfc51ac1e42e7f782ab34 Bug 1358114 https://hg.mozilla.org/integration/mozilla-inbound/rev/6e7b7e621dc3ce728090a7e6fbe74be1e229db69 Bug 1358113 https://hg.mozilla.org/integration/mozilla-inbound/rev/3876d6661539ca114ee4e704efa3dc5f47a45487
Flags: needinfo?(amarchesini)
|
|
Assignee | |
Updated•7 years ago
|
Flags: needinfo?(amarchesini)
Pushed by amarchesini@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/4de83aa3b817 Use IPCBlob in PFilePicker, r=smaug
|
||
Comment 7•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/4de83aa3b817
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•