Closed
Bug 1358115
Opened 7 years ago
Closed 7 years ago
Use IPCBlob in DataTransfer
Categories
(Core :: DOM: Core & HTML, enhancement)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: baku, Assigned: baku)
References
Details
Attachments
(1 file, 1 obsolete file)
7.95 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
This bug is part of the PBlob refactoring
Assignee | ||
Comment 1•7 years ago
|
||
Assignee: nobody → amarchesini
Assignee | ||
Updated•7 years ago
|
Attachment #8860008 -
Flags: review?(bugs)
Updated•7 years ago
|
Attachment #8860008 -
Flags: review?(bugs) → review+
Pushed by amarchesini@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/a10d45c7d6de Use IPCBlob in DataTransfer, r=smaug
Comment 3•7 years ago
|
||
Backed out for failing mochitest test_blob_worker_xhr_read_slice.html: https://hg.mozilla.org/integration/mozilla-inbound/rev/297b5b4a46caaa71f55d5f1e0daf16f0bebfdc03 Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=a10d45c7d6de821757a365b8827691390b55a705&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=93701296&repo=mozilla-inbound [task 2017-04-24T11:13:21.315915Z] 11:13:21 INFO - TEST-START | dom/indexedDB/test/test_blob_worker_xhr_read_slice.html [task 2017-04-24T11:13:21.962912Z] 11:13:21 INFO - TEST-INFO | started process screentopng [task 2017-04-24T11:13:23.240867Z] 11:13:23 INFO - TEST-INFO | screentopng: exit 0 [task 2017-04-24T11:13:23.245576Z] 11:13:23 INFO - Buffered messages logged at 11:13:21 [task 2017-04-24T11:13:23.245842Z] 11:13:23 INFO - Running [task 2017-04-24T11:13:23.246100Z] 11:13:23 INFO - Pushing preferences [task 2017-04-24T11:13:23.247886Z] 11:13:23 INFO - Pushing permissions [task 2017-04-24T11:13:23.250048Z] 11:13:23 INFO - Clearing old databases [task 2017-04-24T11:13:23.252067Z] 11:13:23 INFO - TEST-FAIL | dom/indexedDB/test/test_blob_worker_xhr_read_slice.html | Skipping test in a worker because it's not structured properly [task 2017-04-24T11:13:23.253969Z] 11:13:23 INFO - Running test in main thread [task 2017-04-24T11:13:23.255872Z] 11:13:23 INFO - Setting up [task 2017-04-24T11:13:23.258160Z] 11:13:23 INFO - TEST-PASS | dom/indexedDB/test/test_blob_worker_xhr_read_slice.html | Created database [task 2017-04-24T11:13:23.262175Z] 11:13:23 INFO - Creating objectStore [task 2017-04-24T11:13:23.264245Z] 11:13:23 INFO - TEST-PASS | dom/indexedDB/test/test_blob_worker_xhr_read_slice.html | Opened database [task 2017-04-24T11:13:23.266179Z] 11:13:23 INFO - Adding blob to database [task 2017-04-24T11:13:23.268202Z] 11:13:23 INFO - TEST-PASS | dom/indexedDB/test/test_blob_worker_xhr_read_slice.html | Got a key for the blob [task 2017-04-24T11:13:23.270471Z] 11:13:23 INFO - Getting blob from the database [task 2017-04-24T11:13:23.274742Z] 11:13:23 INFO - TEST-PASS | dom/indexedDB/test/test_blob_worker_xhr_read_slice.html | Got a blob [task 2017-04-24T11:13:23.276955Z] 11:13:23 INFO - TEST-PASS | dom/indexedDB/test/test_blob_worker_xhr_read_slice.html | Correct size [task 2017-04-24T11:13:23.279083Z] 11:13:23 INFO - TEST-PASS | dom/indexedDB/test/test_blob_worker_xhr_read_slice.html | Correct type [task 2017-04-24T11:13:23.281074Z] 11:13:23 INFO - Sending blob to a worker [task 2017-04-24T11:13:23.282950Z] 11:13:23 INFO - Buffered messages finished [task 2017-04-24T11:13:23.285102Z] 11:13:23 INFO - TEST-UNEXPECTED-FAIL | dom/indexedDB/test/test_blob_worker_xhr_read_slice.html | XHR returned expected sliced payload. - got "Green", expected "Gre" [task 2017-04-24T11:13:23.286897Z] 11:13:23 INFO - SimpleTest.is@SimpleTest/SimpleTest.js:310:5 [task 2017-04-24T11:13:23.289488Z] 11:13:23 INFO - testSteps@dom/indexedDB/test/test_blob_worker_xhr_read_slice.html:101:5 [task 2017-04-24T11:13:23.291835Z] 11:13:23 INFO - grabEventAndContinueHandler@dom/indexedDB/test/helpers.js:235:3 [task 2017-04-24T11:13:23.293685Z] 11:13:23 INFO - EventHandlerNonNull*testSteps@dom/indexedDB/test/test_blob_worker_xhr_read_slice.html:98:5 [task 2017-04-24T11:13:23.295651Z] 11:13:23 INFO - grabEventAndContinueHandler@dom/indexedDB/test/helpers.js:235:3 [task 2017-04-24T11:13:23.297520Z] 11:13:23 INFO - EventHandlerNonNull*testSteps@dom/indexedDB/test/test_blob_worker_xhr_read_slice.html:62:5 [task 2017-04-24T11:13:23.299754Z] 11:13:23 INFO - grabEventAndContinueHandler@dom/indexedDB/test/helpers.js:235:3 [task 2017-04-24T11:13:23.301658Z] 11:13:23 INFO - EventHandlerNonNull*testSteps@dom/indexedDB/test/test_blob_worker_xhr_read_slice.html:53:5 [task 2017-04-24T11:13:23.303830Z] 11:13:23 INFO - grabEventAndContinueHandler@dom/indexedDB/test/helpers.js:235:3 [task 2017-04-24T11:13:23.305665Z] 11:13:23 INFO - EventHandlerNonNull*testSteps@dom/indexedDB/test/test_blob_worker_xhr_read_slice.html:43:5 [task 2017-04-24T11:13:23.307402Z] 11:13:23 INFO - grabEventAndContinueHandler@dom/indexedDB/test/helpers.js:235:3 [task 2017-04-24T11:13:23.309373Z] 11:13:23 INFO - EventHandlerNonNull*testSteps@dom/indexedDB/test/test_blob_worker_xhr_read_slice.html:29:5 [task 2017-04-24T11:13:23.311095Z] 11:13:23 INFO - testHarnessSteps@dom/indexedDB/test/helpers.js:200:3 [task 2017-04-24T11:13:23.312897Z] 11:13:23 INFO - nextTestHarnessStep@dom/indexedDB/test/helpers.js:47:5
Flags: needinfo?(amarchesini)
Assignee | ||
Comment 4•7 years ago
|
||
This is an existing bug in PBlob implementation but it's shown only removing this dataTransfer bit (related to nsContentUtils). When a remoteBlobImpl is sliced, if GetInternalStream is called on a different thread, the inputStream is not sliced at all.
Flags: needinfo?(amarchesini)
Attachment #8860962 -
Flags: review?(bugs)
Comment 5•7 years ago
|
||
Comment on attachment 8860962 [details] [diff] [review] fix.patch I don't understand this and neither will whoever reads the code later. Why is the sliced input stream needed? Why it is needed only in } else if (PBackgroundChild* manager = mozilla::ipc::BackgroundChild::GetForCurrentThread()) { case? This needs some good comment, explaining both those questions.
Attachment #8860962 -
Flags: review?(bugs) → review-
Assignee | ||
Comment 6•7 years ago
|
||
Comment on attachment 8860962 [details] [diff] [review] fix.patch I'll move this patch in a separate bug.
Attachment #8860962 -
Attachment is obsolete: true
Pushed by amarchesini@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/2629873b5fdc Use IPCBlob in DataTransfer, r=smaug
Comment 8•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/2629873b5fdc
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•