1358180 - Add more DAMP tests for the console

Status: RESOLVED INVALID

(DevTools :: Console, enhancement, P3)

Description

[Nicolas Chevobbe [:nchevobbe]]

We should have a DAMP test to check the time the console takes to open when there are some messages in cache.
It would also be nice to see how we perform when we log messages with lots of arguments.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Just FYI, DAMP might not survive the move to GitHub, so you may only get results for the next few months or so.  That could still be quite helpful for console, just wanted to make sure you were aware.

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Attachment: console_damp_tests.patch

Comment 3

[Brian Grinstead [:bgrins]]

(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #1)
> Just FYI, DAMP might not survive the move to GitHub, so you may only get
> results for the next few months or so.  That could still be quite helpful
> for console, just wanted to make sure you were aware.

Hm, I wonder if in that case we should move these measurements to be something run locally that we can use for perf testing - either in https://dxr.mozilla.org/mozilla-central/source/devtools/client/webconsole/new-console-output/test/chrome/test_render_perf.html or more likely in a mochitest-browser test

Comment 4

[Brian Grinstead [:bgrins]]

I'll still use this patch for perf testing the html document on try, though

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

Attachment: console_damp_tests.patch

Fixed test

Comment 7

[Alexandre Poirot [:ochameau]]

The new custom page for the console cover various usages of the console (bug 1419328):
https://searchfox.org/mozilla-central/source/testing/talos/talos/tests/devtools/addon/content/pages/custom/console.html#24,30,44

(In reply to Nicolas Chevobbe [:nchevobbe] from comment #0)
> We should have a DAMP test to check the time the console takes to open when
> there are some messages in cache.

The streamlogs + asynclogs being done *after* page load should simulate cached message,
otherwise, the openwithcachedmessages test covers exactly that.

> It would also be nice to see how we perform when we log messages with lots
> of arguments.

The custom page does:
  console.log("sync log", i, window, document.body, bigArray);
Is it enough?
window is a significant JS object. Compared to the attached patch, we don't have an array made of objects.


Do you think we can close this bug, or is there some tweaks to be made, still?

Comment 8

[Nicolas Chevobbe [:nchevobbe]]

Yes, let's close this, we also have other bugs open for specific test case on DAMP like filter. 
Thanks Alex