Closed Bug 1358251 Opened 3 years ago Closed 3 years ago

EnsureSymInitialized shouldn't need to care about the stack walking thread

Categories

(Core :: Gecko Profiler, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: dmajor, Assigned: dmajor)

Details

Attachments

(1 file)

As far as I can tell, the only thing it really cares about is gDbgHelpCS.
Attached patch dbghelpcsSplinter Review
Assignee: nobody → dmajor
Attachment #8860146 - Flags: review?(mstange)
Comment on attachment 8860146 [details] [diff] [review]
dbghelpcs

Review of attachment 8860146 [details] [diff] [review]:
-----------------------------------------------------------------

Seems reasonable. I don't know the code so this was mostly a plausibility inspection rather than an actual review.
Attachment #8860146 - Flags: review?(mstange) → review+
Pushed by dmajor@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8868bb11e7a8
EnsureSymInitialized doesn't need to EnsureWalkThreadReady. r=mstange
Backout by kwierso@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5501d934a1ee
Backed out changeset 8868bb11e7a8 for assertions on Windows
Flags: needinfo?(dmajor)
Depends on: 1360234
No longer depends on: 1360234
Pushed by dmajor@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/44686b514b05
EnsureSymInitialized doesn't need to EnsureWalkThreadReady. r=mstange
Flags: needinfo?(dmajor)
Pushed by dmajor@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5dc6f1a89b79
EnsureSymInitialized doesn't need to EnsureWalkThreadReady. r=mstange
https://hg.mozilla.org/mozilla-central/rev/5dc6f1a89b79
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.