Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Stagefright-vs-Rust TrackInfo comparison is incorrect, leading to false reports

RESOLVED FIXED in Firefox 55

Status

()

Core
Audio/Video: Playback
P1
normal
RESOLVED FIXED
3 months ago
3 months ago

People

(Reporter: gerald, Assigned: gerald)

Tracking

55 Branch
mozilla55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

3 months ago
As per bug 1341483 comment 27:

Someone blog posted(http://blog.goo.ne.jp/atlanto/e/2cdc3c75132f7353c89e9eebc4f00a73):

the patch  attachment 8847073 [details] seems logically wrong.

https://dxr.mozilla.org/mozilla-central/source/media/libstagefright/binding/MP4Metadata.cpp#394

GetDifferentField(const mozilla::TrackInfo& info,
                  const mozilla::TrackInfo& infoRust)
{
  if (infoRust.mId != info.mId) { return "Id"; }
  if (infoRust.mKind == info.mKind) { return "Kind"; }
  ...


All most of "=="  seems typo, they should be "!=".
So, a lot of "Report Site Issue" notification pop up like a storm.
Comment hidden (mozreview-request)

Comment 2

3 months ago
mozreview-review
Comment on attachment 8860187 [details]
Bug 1358287 - Stagefright-vs-Rust TrackInfo comparison was incorrect -

https://reviewboard.mozilla.org/r/132216/#review135074
Attachment #8860187 - Flags: review?(ayang) → review+
John, I think that's what we saw yesterday, a false alarm.
Flags: needinfo?(jolin)

Comment 4

3 months ago
Pushed by gsquelart@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/801168366d99
Stagefright-vs-Rust TrackInfo comparison was incorrect - r=alfredo
Priority: -- → P1
https://hg.mozilla.org/mozilla-central/rev/801168366d99
Status: NEW → RESOLVED
Last Resolved: 3 months ago
status-firefox55: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Flags: needinfo?(jolin)
You need to log in before you can comment on or make changes to this bug.