Closed Bug 1358287 Opened 3 years ago Closed 3 years ago

Stagefright-vs-Rust TrackInfo comparison is incorrect, leading to false reports

Categories

(Core :: Audio/Video: Playback, defect, P1)

55 Branch
defect

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: gerald, Assigned: gerald)

References

Details

Attachments

(1 file)

As per bug 1341483 comment 27:

Someone blog posted(http://blog.goo.ne.jp/atlanto/e/2cdc3c75132f7353c89e9eebc4f00a73):

the patch  attachment 8847073 [details] seems logically wrong.

https://dxr.mozilla.org/mozilla-central/source/media/libstagefright/binding/MP4Metadata.cpp#394

GetDifferentField(const mozilla::TrackInfo& info,
                  const mozilla::TrackInfo& infoRust)
{
  if (infoRust.mId != info.mId) { return "Id"; }
  if (infoRust.mKind == info.mKind) { return "Kind"; }
  ...


All most of "=="  seems typo, they should be "!=".
So, a lot of "Report Site Issue" notification pop up like a storm.
Comment on attachment 8860187 [details]
Bug 1358287 - Stagefright-vs-Rust TrackInfo comparison was incorrect -

https://reviewboard.mozilla.org/r/132216/#review135074
Attachment #8860187 - Flags: review?(ayang) → review+
John, I think that's what we saw yesterday, a false alarm.
Flags: needinfo?(jolin)
Pushed by gsquelart@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/801168366d99
Stagefright-vs-Rust TrackInfo comparison was incorrect - r=alfredo
Priority: -- → P1
https://hg.mozilla.org/mozilla-central/rev/801168366d99
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Flags: needinfo?(jolin)
You need to log in before you can comment on or make changes to this bug.