Closed Bug 1358299 Opened 5 years ago Closed 4 years ago

Remove the BOX_ALIGN_PROPS_IN_BLOCKS_FLAG probe code and histogram

Categories

(Core :: Layout: Block and Inline, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: bradwerth, Assigned: bradwerth)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

The probe expires in 57. The code and histogram should be taken out after the 56 merge date for Nightly; currently scheduled for 6/12/2017.
Blocks: 1406390
Comment on attachment 8918427 [details]
Bug 1358299 Part 1: Stop collecting data for BOX_ALIGN_PROPS_IN_BLOCKS_FLAG probe.

https://reviewboard.mozilla.org/r/189252/#review194574
Attachment #8918427 - Flags: review+
Attachment #8918429 - Flags: review?(chutten)
(In reply to Chris H-C :chutten from comment #2)
Whoops, I split the patch at the same time you r+ the unified patch. I'm requesting review on Part 2 now.
Comment on attachment 8918429 [details]
Bug 1358299 Part 2: Remove the histogram definition for BOX_ALIGN_PROPS_IN_BLOCKS_FLAG.

https://reviewboard.mozilla.org/r/189254/#review194578
Attachment #8918429 - Flags: review?(chutten) → review+
Sorry I jumped the gun :)
Pushed by bwerth@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0cd1372b3fa9
Part 1: Stop collecting data for BOX_ALIGN_PROPS_IN_BLOCKS_FLAG probe. r=chutten
https://hg.mozilla.org/integration/autoland/rev/83ae3528255f
Part 2: Remove the histogram definition for BOX_ALIGN_PROPS_IN_BLOCKS_FLAG. r=chutten
https://hg.mozilla.org/mozilla-central/rev/0cd1372b3fa9
https://hg.mozilla.org/mozilla-central/rev/83ae3528255f
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.