1358299 - Remove the BOX_ALIGN_PROPS_IN_BLOCKS_FLAG probe code and histogram

Status: RESOLVED FIXED

(Core :: Layout: Block and Inline, enhancement)

Description

[Brad Werth [:bradwerth]]

The probe expires in 57. The code and histogram should be taken out after the 56 merge date for Nightly; currently scheduled for 6/12/2017.

Comment 1

[Brad Werth [:bradwerth]]

Attachment: Bug 1358299 Part 1: Stop collecting data for BOX_ALIGN_PROPS_IN_BLOCKS_FLAG probe.

Review commit: https://reviewboard.mozilla.org/r/189252/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/189252/

Comment 2

[Chris H-C :chutten]

Comment on attachment 8918427 [details]
Bug 1358299 Part 1: Stop collecting data for BOX_ALIGN_PROPS_IN_BLOCKS_FLAG probe.

https://reviewboard.mozilla.org/r/189252/#review194574

Comment 3

[Brad Werth [:bradwerth]]

Attachment: Bug 1358299 Part 2: Remove the histogram definition for BOX_ALIGN_PROPS_IN_BLOCKS_FLAG.

Review commit: https://reviewboard.mozilla.org/r/189254/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/189254/

Comment 4

[Brad Werth [:bradwerth]]

Comment on attachment 8918427 [details]
Bug 1358299 Part 1: Stop collecting data for BOX_ALIGN_PROPS_IN_BLOCKS_FLAG probe.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/189252/diff/1-2/

Comment 5

[Brad Werth [:bradwerth]]

(In reply to Chris H-C :chutten from comment #2)
Whoops, I split the patch at the same time you r+ the unified patch. I'm requesting review on Part 2 now.

Comment 6

[Chris H-C :chutten]

Comment on attachment 8918429 [details]
Bug 1358299 Part 2: Remove the histogram definition for BOX_ALIGN_PROPS_IN_BLOCKS_FLAG.

https://reviewboard.mozilla.org/r/189254/#review194578

Comment 7

[Chris H-C :chutten]

Sorry I jumped the gun :)

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0cd1372b3fa9
Part 1: Stop collecting data for BOX_ALIGN_PROPS_IN_BLOCKS_FLAG probe. r=chutten
https://hg.mozilla.org/integration/autoland/rev/83ae3528255f
Part 2: Remove the histogram definition for BOX_ALIGN_PROPS_IN_BLOCKS_FLAG. r=chutten

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/0cd1372b3fa9
https://hg.mozilla.org/mozilla-central/rev/83ae3528255f