1358310 - eslint-plugin-mozilla gets stuck in a loop looking for .eslintignore when used outside mozilla-central

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, defect)

Description

[Michael Cooper [:mythmon]]

When searching for the root of the current repository [0], eslint-plugin-mozilla has a loop like this

  while (dirName && !fs.existsSync(path.join(dirName, ".eslintignore"))) {
    dirName = path.dirname(dirName);
  }

This assumes that when the loop gets to the "top" of the file system, dirname will return a falsey value and the loop will terminate. Instead |path.dirname("/")| returns "/" and |path.dirname("C:/")| returns "C:/". This causes an infinite loop.

With this fixed, external users of eslint-plugin-mozilla will get an error, because the root directory can't be found, which is at least better than a hang.

[0]: https://dxr.mozilla.org/mozilla-central/rev/20dff607fb88ee69135a280bbb7f32df75a86237/tools/lint/eslint/eslint-plugin-mozilla/lib/helpers.js#528-530

Comment 1

[Michael Cooper [:mythmon]]

Attachment: Bug 1358310 - eslint-plugin-mozilla: Fix infinite loop when finding repo root.

Review commit: https://reviewboard.mozilla.org/r/133578/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/133578/

Comment 2

[Dave Townsend [:mossop]]

Comment on attachment 8861610 [details]
Bug 1358310 - eslint-plugin-mozilla: Fix infinite loop when finding repo root.

https://reviewboard.mozilla.org/r/133578/#review136490

Comment 3

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 0664f683e605 -d 73b97e528623: rebasing 391730:0664f683e605 "Bug 1358310 - eslint-plugin-mozilla: Fix infinite loop when finding repo root. r=mossop" (tip)
merging tools/lint/eslint/eslint-plugin-mozilla/lib/helpers.js
merging tools/lint/eslint/eslint-plugin-mozilla/package.json
warning: conflicts while merging tools/lint/eslint/eslint-plugin-mozilla/package.json! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 4

[Michael Cooper [:mythmon]]

Comment on attachment 8861610 [details]
Bug 1358310 - eslint-plugin-mozilla: Fix infinite loop when finding repo root.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/133578/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c1db498519cd
eslint-plugin-mozilla: Fix infinite loop when finding repo root. r=mossop

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c1db498519cd