Closed Bug 1358333 Opened 3 years ago Closed 3 years ago

The APPLICATION_REPUTATION_ALLOWLIST_MATCH and APPLICATION_REPUTATION_BLOCKLIST_MATCH probes don't seem to be working correctly

Categories

(Toolkit :: Safe Browsing, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: francois, Assigned: tnguyen)

References

Details

(Whiteboard: #sbv4-m7)

Attachments

(1 file)

Ah, I see in [1]
https://searchfox.org/mozilla-central/rev/7aa21f3b531ddee90a353215bd86e97d6974e25b/toolkit/components/downloads/ApplicationReputation.cpp#439
The tables will not contain any V4 list until V4 result is taken (bug 1329817 landed 2 days ago will enable V4 table result).
(In reply to Thomas Nguyen[:tnguyen] ni plz from comment #1)
> The tables will not contain any V4 list until V4 result is taken (bug
> 1329817 landed 2 days ago will enable V4 table result).

Doesn't that mean that we should be seeing only matches in V2 tables then? The telemetry shows only matches in V4 tables.
Sorry I was wrong, :(, plz ignore that
I think I did copy/paste things then compared wrong table :(
Comment on attachment 8860257 [details]
Bug 1358333 - Fix APPLICATION_REPUTATION_ALLOWLIST_MATCH and APPLICATION_REPUTATION_BLOCKLIST_MATCH telemetry

https://reviewboard.mozilla.org/r/132266/#review135144
Attachment #8860257 - Flags: review?(francois) → review+
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fee151a11c16
Fix APPLICATION_REPUTATION_ALLOWLIST_MATCH and APPLICATION_REPUTATION_BLOCKLIST_MATCH telemetry r=francois
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/fee151a11c16
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Assignee: nobody → tnguyen
You need to log in before you can comment on or make changes to this bug.