1358333 - The APPLICATION_REPUTATION_ALLOWLIST_MATCH and APPLICATION_REPUTATION_BLOCKLIST_MATCH probes don't seem to be working correctly

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, enhancement, P2)

Description

[François Marier [:francois]]

The two Application Reputation probes that were added in bug 1331139 suggest that the V2 lists (whitelist or blacklist) for Application Reputation never return any matches while the V4 list does:

https://telemetry.mozilla.org/new-pipeline/dist.html#!cumulative=0&end_date=2017-04-19&keys=__none__!__none__!__none__&max_channel_version=nightly%252F55&measure=APPLICATION_REPUTATION_ALLOWLIST_MATCH&min_channel_version=null&processType=*&product=Firefox&sanitize=1&sort_keys=submissions&start_date=2017-03-08&table=1&trim=1&use_submission_date=0
https://telemetry.mozilla.org/new-pipeline/dist.html#!cumulative=0&end_date=2017-04-19&keys=__none__!__none__!__none__&max_channel_version=nightly%2F55&measure=APPLICATION_REPUTATION_BLOCKLIST_MATCH&min_channel_version=null&processType=*&product=Firefox&sanitize=1&sort_keys=submissions&start_date=2017-03-08&table=1&trim=1&use_submission_date=0

(start=2 is for V4 only matches)

That's obviously not true because we have matches on both lists in Beta where only V2 is enabled:

https://telemetry.mozilla.org/new-pipeline/dist.html#!cumulative=0&end_date=2017-04-12&keys=__none__!__none__!__none__&max_channel_version=beta%252F53&measure=APPLICATION_REPUTATION_LOCAL&min_channel_version=null&processType=*&product=Firefox&sanitize=1&sort_keys=submissions&start_date=2017-03-07&table=1&trim=1&use_submission_date=0

Comment 1

[Thomas Nguyen (:tnguyen)]

Ah, I see in [1]
https://searchfox.org/mozilla-central/rev/7aa21f3b531ddee90a353215bd86e97d6974e25b/toolkit/components/downloads/ApplicationReputation.cpp#439
The tables will not contain any V4 list until V4 result is taken (bug 1329817 landed 2 days ago will enable V4 table result).

Comment 2

[François Marier [:francois]]

(In reply to Thomas Nguyen[:tnguyen] ni plz from comment #1)
> The tables will not contain any V4 list until V4 result is taken (bug
> 1329817 landed 2 days ago will enable V4 table result).

Doesn't that mean that we should be seeing only matches in V2 tables then? The telemetry shows only matches in V4 tables.

Comment 3

[Thomas Nguyen (:tnguyen)]

Yep, you are right, the wrong thing is https://searchfox.org/mozilla-central/rev/7aa21f3b531ddee90a353215bd86e97d6974e25b/toolkit/components/downloads/ApplicationReputation.cpp#135
skipped only v2/v4 results

Comment 4

[Thomas Nguyen (:tnguyen)]

Sorry I was wrong, :(, plz ignore that

Comment 5

[Thomas Nguyen (:tnguyen)]

Attachment: Bug 1358333 - Fix APPLICATION_REPUTATION_ALLOWLIST_MATCH and APPLICATION_REPUTATION_BLOCKLIST_MATCH telemetry

Review commit: https://reviewboard.mozilla.org/r/132266/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/132266/

Comment 6

[Thomas Nguyen (:tnguyen)]

I think I did copy/paste things then compared wrong table :(

Comment 7

[François Marier [:francois]]

Comment on attachment 8860257 [details]
Bug 1358333 - Fix APPLICATION_REPUTATION_ALLOWLIST_MATCH and APPLICATION_REPUTATION_BLOCKLIST_MATCH telemetry

https://reviewboard.mozilla.org/r/132266/#review135144

Comment 8

[Thomas Nguyen (:tnguyen)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f8d298825a439d92bce16e74089fa83640ff0d1f

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fee151a11c16
Fix APPLICATION_REPUTATION_ALLOWLIST_MATCH and APPLICATION_REPUTATION_BLOCKLIST_MATCH telemetry r=francois

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/fee151a11c16