1358339 - AUS Helper not working as expected in partner repack

Status: RESOLVED DUPLICATE of bug 1358342

(Toolkit :: Application Update, defect)

Description

[Hector Zhao [:hectorz]]

We at Beijing office just noticed a very slow uptick of Fx 52.0.2 in China. [1] I wished we were monitoring this more closely but sadly that's not the case.

This symptom is a direct result of "Fixing WebSense update rules" which starts to "block users with unknown WebSense status from updating". I believe this rule is no longer applied since Fx 53.

The root cause, however, is the existence of distribution.ini in Fx China repack distributed by Beijing office (and similarly, any other partner repack). It will trigger a "reload-default-prefs" notification, and invalidates any change made to an existing preference on default branch before it.

Please take this into consideration in future versions of aushelper.

[1]: https://sql.telemetry.mozilla.org/queries/1432
[2]: https://dxr.mozilla.org/mozilla-central/rev/27311156637f/browser/components/distribution.js#250

Comment 1

[Robert Strong (they/them - no direct email)]

The best that app update can do is move the code into UpdateUtils.jsm since system add-ons have several issues as noted in bug 1358342. So, duping over to bug 1358342.

Comment 2

[Mike Kaply [:mkaply]]

Are you saying that partner repacks aren't getting updates to Firefox?

Comment 3

[Hector Zhao [:hectorz]]

(In reply to Mike Kaply [:mkaply] from comment #2)
> Are you saying that partner repacks aren't getting updates to Firefox?

Not as severe as it sounds.

The combination of this bug and a condition in the update rule prevented users on 52.0.1 and before to be updated to Fx 52.0.2, as shown in my re:dash query. I believe they're being updated to Fx 53, since the condition mentioned before does not apply to Fx 53.