Closed Bug 1358341 Opened 4 years ago Closed 4 years ago

Port bug 1354349 to mailnews: Add GetIsDocument() to IMAP, NNTP, MsgProtocol

Categories

(MailNews Core :: Networking, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 55.0

People

(Reporter: ewong, Assigned: ewong)

Details

Attachments

(1 file, 1 obsolete file)

getting this bustage on c-c:

    INPUT("../../modules/zlib/src/gzread.o")
    INPUT("../../modules/zlib/src/gzwrite.o")
    INPUT("../../modules/zlib/src/infback.o")
    INPUT("../../modules/zlib/src/inffast.o")
    INPUT("../../modules/zlib/src/inflate.o")
    INPUT("../../modules/zlib/src/inftrees.o")
    INPUT("../../modules/zlib/src/trees.o")
    INPUT("../../modules/zlib/src/uncompr.o")
    INPUT("../../modules/zlib/src/zutil.o")
    INPUT("StaticXULComponentsEnd/StaticXULComponentsEnd.o")

/builds/slave/c-cen-t-lnx/build/gcc/bin/../lib/gcc/x86_64-unknown-linux-gnu/4.9.4/../../../../x86_64-unknown-linux-gnu/bin/ld: /lib64/libz.so.1: no version information available (required by /builds/slave/c-cen-t-lnx/build/gcc/bin/../lib/gcc/x86_64-unknown-linux-gnu/4.9.4/../../../../x86_64-unknown-linux-gnu/bin/ld)
../../mailnews/base/util/nsMsgProtocol.o:(.data.rel.ro._ZTV13nsMsgProtocol[_ZTV13nsMsgProtocol]+0x84): undefined reference to `nsMsgProtocol::GetIsDocument(bool*)'
../../mailnews/base/util/nsMsgProtocol.o:(.data.rel.ro._ZTV13nsMsgProtocol[_ZTV13nsMsgProtocol]+0x194): undefined reference to `non-virtual thunk to nsMsgProtocol::GetIsDocument(bool*)'
../../mailnews/base/util/nsMsgProtocol.o:(.data.rel.ro._ZTV23nsMsgAsyncWriteProtocol[_ZTV23nsMsgAsyncWriteProtocol]+0x84): undefined reference to `nsMsgProtocol::GetIsDocument(bool*)'
../../mailnews/base/util/nsMsgProtocol.o:(.data.rel.ro._ZTV23nsMsgAsyncWriteProtocol[_ZTV23nsMsgAsyncWriteProtocol]+0x194): undefined reference to `non-virtual thunk to nsMsgProtocol::GetIsDocument(bool*)'
../../mailnews/compose/src/nsSmtpProtocol.o:(.data.rel.ro._ZTV14nsSmtpProtocol[_ZTV14nsSmtpProtocol]+0x84): undefined reference to `nsMsgProtocol::GetIsDocument(bool*)'
../../mailnews/compose/src/nsSmtpProtocol.o:(.data.rel.ro._ZTV14nsSmtpProtocol[_ZTV14nsSmtpProtocol]+0x1a0): undefined reference to `non-virtual thunk to nsMsgProtocol::GetIsDocument(bool*)'
../../mailnews/imap/src/nsImapProtocol.o:(.data.rel.ro._ZTV14nsImapProtocol[_ZTV14nsImapProtocol]+0x190): undefined reference to `nsMsgProtocol::GetIsDocument(bool*)'
../../mailnews/imap/src/nsImapProtocol.o:(.data.rel.ro._ZTV14nsImapProtocol[_ZTV14nsImapProtocol]+0x2a0): undefined reference to `non-virtual thunk to nsMsgProtocol::GetIsDocument(bool*)'
../../mailnews/imap/src/nsImapProtocol.o:(.data.rel.ro.local._ZTV17nsImapMockChannel[_ZTV17nsImapMockChannel]+0xa0): undefined reference to `nsImapMockChannel::GetIsDocument(bool*)'
../../mailnews/local/src/nsPop3Protocol.o:(.data.rel.ro._ZTV14nsPop3Protocol[_ZTV14nsPop3Protocol]+0x84): undefined reference to `nsMsgProtocol::GetIsDocument(bool*)'
../../mailnews/local/src/nsPop3Protocol.o:(.data.rel.ro._ZTV14nsPop3Protocol[_ZTV14nsPop3Protocol]+0x1b4): undefined reference to `non-virtual thunk to nsMsgProtocol::GetIsDocument(bool*)'
../../mailnews/news/src/nsNNTPProtocol.o:(.data.rel.ro._ZTV14nsNNTPProtocol[_ZTV14nsNNTPProtocol]+0x84): undefined reference to `nsMsgProtocol::GetIsDocument(bool*)'
../../mailnews/news/src/nsNNTPProtocol.o:(.data.rel.ro._ZTV14nsNNTPProtocol[_ZTV14nsNNTPProtocol]+0x1d8): undefined reference to `non-virtual thunk to nsMsgProtocol::GetIsDocument(bool*)'
../../mailnews/local/src/nsMailboxProtocol.o:(.data.rel.ro._ZTV17nsMailboxProtocol[_ZTV17nsMailboxProtocol]+0x84): undefined reference to `nsMsgProtocol::GetIsDocument(bool*)'
../../mailnews/local/src/nsMailboxProtocol.o:(.data.rel.ro._ZTV17nsMailboxProtocol[_ZTV17nsMailboxProtocol]+0x194): undefined reference to `non-virtual thunk to nsMsgProtocol::GetIsDocument(bool*)'
../../mailnews/news/src/nsNntpMockChannel.o:(.data.rel.ro.local._ZTV17nsNntpMockChannel[_ZTV17nsNntpMockChannel]+0xa0): undefined reference to `nsNntpMockChannel::GetIsDocument(bool*)'
/builds/slave/c-cen-t-lnx/build/gcc/bin/../lib/gcc/x86_64-unknown-linux-gnu/4.9.4/../../../../x86_64-unknown-linux-gnu/bin/ld: libxul.so: hidden symbol `_ZN17nsNntpMockChannel13GetIsDocumentEPb' isn't defined
/builds/slave/c-cen-t-lnx/build/gcc/bin/../lib/gcc/x86_64-unknown-linux-gnu/4.9.4/../../../../x86_64-unknown-linux-gnu/bin/ld: final link failed: Bad value
collect2: error: ld returned 1 exit status
make[4]: *** [libxul.so] Error 1
make[4]: Leaving directory `/builds/slave/c-cen-t-lnx/build/objdir/toolkit/library'
make[3]: *** [toolkit/library/target] Error 2
Thanks for starting here. The links you pasted don't work. Correct is:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=73a0294fa14565521adac01574ab148a768ba564

There are three unresolved externs:
nsMsgProtocol::GetIsDocument
nsImapMockChannel::GetIsDocument
nsNntpMockChannel::GetIsDocument

so you need to add the new method three times. And I don't think you need to change header files.

Let me adjust your patch accordingly.
Attached patch 1358341.patch (obsolete) — Splinter Review
This should do it. I'll compile locally before landing.

Thanks again. Will of course be landed as your work!
Well perhaps a fast Mac try is faster than my local build:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=5963b4ffc9a13ee743a6ad20fdc4d6b06f968970
Assignee: nobody → ewong
Component: Build Config → Networking
OS: Unspecified → All
Hardware: Unspecified → All
Summary: /mailnews/base/util/nsMsgProtocol.o: undefined reference to `nsMsgProtocol::GetIsDocument(bool*)' → Port bug 1354349 to mailnews: Add GetIsDocument() to IMAP, NNTP, MsgProtocol
Version: unspecified → Trunk
Sigh, semicolon missing.
Attachment #8860278 - Attachment is obsolete: true
Comment on attachment 8860282 [details] [diff] [review]
1358341.patch (v1b).

Straight port of, for example:
https://hg.mozilla.org/mozilla-central/rev/b01181410a8a#l12.12
Attachment #8860282 - Flags: review+
https://hg.mozilla.org/comm-central/rev/7e82cc51efb47557a5568f331c28a55429274a46

Edmund, thanks a lot for your work! You did 95% of it, I've just added the missing 5% ;-)
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 55.0
You need to log in before you can comment on or make changes to this bug.