1358345 - dom/security/nsContentSecurityManager.cpp has two #include "nsIStreamListener.h"

Status: RESOLVED DUPLICATE of bug 1754767

(Core :: DOM: Security, enhancement, P3)

Description

[Edmund Wong (:ewong)]

line #4 and line #8 contains #include "nsIStreamListener.h".

according to :jdm on irc, it's not necessary.

filing this bug.

Comment 1

[Edmund Wong (:ewong)]

Attachment: Bug 1358345 - Remove extra instance of #include 'nsIStreamListener.h'

Review commit: https://reviewboard.mozilla.org/r/132274/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/132274/

Comment 2

[Christoph Kerschbaumer [:ckerschb]]

Comment on attachment 8860260 [details]
Bug 1358345 - Remove extra instance of #include 'nsIStreamListener.h'

https://reviewboard.mozilla.org/r/132274/#review135186

Thanks - please update the commit message though!

Comment 3

[Edmund Wong (:ewong)]

Comment on attachment 8860260 [details]
Bug 1358345 - Remove extra instance of #include 'nsIStreamListener.h'

https://reviewboard.mozilla.org/r/132274/#review135186

pardon my ignorance, but what's the mozreview way of updating the commit message?  (more so, what exactly do I update it to?)

Comment 4

[Christoph Kerschbaumer [:ckerschb]]

I am not really using mozreview, but I would imagine it's the same as a regular commit message:

hg qrefresh -m "Bug 1358345 - Remove extra instance of #include 'nsIStreamListener.h'. r=ckerschb"

Comment 5

[Edmund Wong (:ewong)]

Comment on attachment 8860260 [details]
Bug 1358345 - Remove extra instance of #include 'nsIStreamListener.h'

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/132274/diff/1-2/

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Moving to p3 because no activity for at least 1 year(s).
See https://github.com/mozilla/bug-handling/blob/master/policy/triage-bugzilla.md#how-do-you-triage for more information

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Comment 8

[Edmund Wong (:ewong)]

I don't even think this is even applicable anymore. Was fixed in bug 1754767.