1358387 - 1.02ms uninterruptible reflow at set_label@chrome://browser/content/tabbrowser.xml:7593:37

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect, P1)

Description

[Hazel Ward]

Here's the stack:

set_label@chrome://browser/content/tabbrowser.xml:7593:37
updateStatusField@chrome://browser/content/browser.js:4512:7
onStatusChange@chrome://browser/content/browser.js:4799:5
XWB_onUpdateCurrentBrowser@chrome://browser/content/browser.js:4860:5
callListeners@chrome://browser/content/tabbrowser.xml:492:24
_callProgressListeners@chrome://browser/content/tabbrowser.xml:507:13
updateCurrentBrowser@chrome://browser/content/tabbrowser.xml:1159:15
onselect@chrome://browser/content/browser.xul:1:44
set_selectedIndex@chrome://browser/content/tabbrowser.xml:7706:13
set_selectedPanel@chrome://global/content/bindings/tabbox.xml:691:13
set_selectedIndex@chrome://global/content/bindings/tabbox.xml:409:15
set_selectedItem@chrome://global/content/bindings/tabbox.xml:441:34
set_selectedTab@chrome://global/content/bindings/tabbox.xml:111:15
set_selectedTab@chrome://browser/content/tabbrowser.xml:3341:11
_blurTab@chrome://browser/content/tabbrowser.xml:2908:13
removeTab@chrome://browser/content/tabbrowser.xml:2599:13
removeCurrentTab@chrome://browser/content/tabbrowser.xml:2530:13
BrowserCloseTabOrWindow@chrome://browser/content/browser.js:2241:3
oncommand@chrome://browser/content/browser.xul:1:1
permitUnload@chrome://global/content/bindings/remote-browser.xml:357:13
_beginRemoveTab@chrome://browser/content/tabbrowser.xml:2644:46
removeTab@chrome://browser/content/tabbrowser.xml:2571:18
removeCurrentTab@chrome://browser/content/tabbrowser.xml:2530:13
BrowserCloseTabOrWindow@chrome://browser/content/browser.js:2241:3
oncommand@chrome://browser/content/browser.xul:1:1

Comment 1

[Florian Quèze [:florian]]

In bug 1356663 we removed the sync flush at http://searchfox.org/mozilla-central/rev/7aa21f3b531ddee90a353215bd86e97d6974e25b/browser/base/content/tabbrowser.xml#7597 but there's another one 5 lines above with "getComputedStyle(this).width".

Dão, do you know what this code is doing? It seems to be trying to get the width of the panel before we change its value. It's not clear to me what the goal of this is (do we want to prevent that panel from shrinking when the message changes?), but if it's correct, this sync flush looks like a good candidate for fixing with getBoundsWithoutFlushing.

Comment 2

[Dão Gottwald [:dao]]

(In reply to Florian Quèze [:florian] [:flo] from comment #1)
> Dão, do you know what this code is doing? It seems to be trying to get the
> width of the panel before we change its value. It's not clear to me what the
> goal of this is (do we want to prevent that panel from shrinking when the
> message changes?)

Yep.

Comment 3

[Brian Carpenter [:geeknik]]

Another stack:

set_label@chrome://browser/content/tabbrowser.xml:7706:37
updateStatusField@chrome://browser/content/browser.js:4547:7
onStatusChange@chrome://browser/content/browser.js:4834:5
callListeners@chrome://browser/content/tabbrowser.xml:492:24
_callProgressListeners@chrome://browser/content/tabbrowser.xml:507:13
_callProgressListeners@chrome://browser/content/tabbrowser.xml:563:22
onStatusChange@chrome://browser/content/tabbrowser.xml:860:15

Comment 4

[Dão Gottwald [:dao]]

Attachment: Bug 1358387 - Avoid style flush when setting the statuspanel's current width as its min-width on status label changes.

Review commit: https://reviewboard.mozilla.org/r/143608/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/143608/

Comment 5

[Florian Quèze [:florian]]

Comment on attachment 8872118 [details]
Bug 1358387 - Avoid style flush when setting the statuspanel's current width as its min-width on status label changes.

https://reviewboard.mozilla.org/r/143608/#review147538

Thanks!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d2ee41a263fc
Avoid style flush when setting the statuspanel's current width as its min-width on status label changes. r=florian

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d2ee41a263fc