Closed Bug 1358394 Opened 4 years ago Closed 4 years ago

Crash report-enabling checkbox should be grouped under the Reports group

Categories

(Firefox :: Preferences, enhancement, P1)

enhancement

Tracking

()

VERIFIED FIXED
Firefox 55
Tracking Status
firefox55 --- fixed
firefox57 --- verified

People

(Reporter: Fischer, Assigned: timdream)

References

(Blocks 1 open bug)

Details

(Whiteboard: [photon-preference])

Attachments

(2 files)

Based on the UX spec[1], the Crash report-enabling checkbox should be grouped under the Reports group. However, the current implementation[2] is not under the Reports group. If no MOZ_TELEMETRY_REPORTING defined, we would see the Crash report-enabling checkbox is grouped under the Cached Web Content group visually (See crash_report_checkbox_under_cached_web_content.png)

[1] https://mozilla.invisionapp.com/share/P4ACQT1E3#/screens/217167680
[2] https://dxr.mozilla.org/mozilla-central/rev/27311156637f9b5d4504373967e01c4241902ae7/browser/components/preferences/in-content/privacy.xul#752
Whiteboard: [photon-preference]
Should be easy to fix by duplicate

<caption><label>&reports.label;</label></caption>

and wrap it in the right ifdefs?
Assignee: nobody → timdream
Status: NEW → ASSIGNED
Comment on attachment 8860396 [details]
Bug 1358394 - Ensure "Reports" section caption is shown without telemetry section,

https://reviewboard.mozilla.org/r/132408/#review135344
Attachment #8860396 - Flags: review?(jaws) → review+
Pushed by ihsiao@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/df49ddc506e8
Ensure "Reports" section caption is shown without telemetry section, r=jaws
Keywords: checkin-needed
Target Milestone: --- → Firefox 55
https://hg.mozilla.org/mozilla-central/rev/df49ddc506e8
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Flags: qe-verify+
QA Contact: hani.yacoub
Priority: -- → P1
I'm trying to verify this bug on Nightly 57 but I couldn't find the Crash report-enabling checkbox.
Is there any preferences that I can use to see it?
Flags: needinfo?(fliu)
This is a FF55 bug. In FF57, about:preferences has beed reorged.
If you would like to see the the Crash report-enabling checkbox in FF57, please go to about:preferences > Privacy & Security > Nightly Data Collection and Use
Flags: needinfo?(fliu)
Build ID: 20170816100153
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0

Verified as fixed on Firefox Nightly 57.0a1 on Windows 10 x 64, Mac OS X 10.12 and Ubuntu 16.04 x64 that the Crash report-enabling checkbox is correctly displayed now in about:preferences > Privacy & Security > Nightly Data Collection and Use.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.