Closed Bug 1358397 Opened 7 years ago Closed 7 years ago

1.48ms uninterruptible reflow at showLearn@chrome://browser/content/newtab/newTab.js:2613:5

Categories

(Firefox :: New Tab Page, defect, P4)

Product:
Firefox
Component:
New Tab Page
Type:
defect

Tracking

()

Status:
RESOLVED WONTFIX
Project Flags:
Performance Impact medium

People

(Reporter: rjward0, Unassigned)

References

(Blocks 1 open bug)

Details

(Keywords: perf, Whiteboard: [ohnoreflow][reserve-photon-performance]) 

Here's the stack:

showLearn@chrome://browser/content/newtab/newTab.js:2613:5
onClick@chrome://browser/content/newtab/newTab.js:2601:9
handleEvent@chrome://browser/content/newtab/newTab.js:2572:9
EventListener.handleEvent*init@chrome://browser/content/newtab/newTab.js:2531:5
Page_init@chrome://browser/content/newtab/newTab.js:354:5
@chrome://browser/content/newtab/newTab.js:2638:1
Component: Untriaged → New Tab Page
Flags: qe-verify?
Priority: -- → P2
The only showLearn method I can find in newTab.js is http://searchfox.org/mozilla-central/rev/7aa21f3b531ddee90a353215bd86e97d6974e25b/browser/base/content/newtab/customize.js#110 (#included by the newTab.js source file), but I don't see how that causes a sync reflow.
Priority: P2 → P3
Whiteboard: [ohnoreflow][qf][photon-performance] → [ohnoreflow][qf][reserve-photon-performance]
Possible that the window.open call causes a style flush in our native layer.
Whiteboard: [ohnoreflow][qf][reserve-photon-performance] → [ohnoreflow][qf:p1][reserve-photon-performance]
(In reply to Mike Conley (:mconley) - PTO on April 28th. from comment #2)
> Possible that the window.open call causes a style flush in our native layer.

Window activation does (when it sets the focus), so... I would guess a new window gets activated while being opened.
Flags: qe-verify? → qe-verify-
Whiteboard: [ohnoreflow][qf:p1][reserve-photon-performance] → [ohnoreflow][qf:p2][reserve-photon-performance]
Priority: P3 → P4
Keywords: perf
Tiles newtab has been superseded by Activity Stream, so I think this bug is WONTFIX.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
Performance Impact: --- → P2
Whiteboard: [ohnoreflow][qf:p2][reserve-photon-performance] → [ohnoreflow][reserve-photon-performance]
You need to log in before you can comment on or make changes to this bug.