Improve the error handling of eme.js

RESOLVED FIXED in Firefox 55

Status

()

enhancement
P3
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jwwang, Assigned: jwwang)

Tracking

unspecified
mozilla55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(4 attachments)

Per bug 1358399 comment 0, we want to propagate the error to the client code which can finish the test and continue to run other tests to catch as many errors as possible in one test run.
Assignee: nobody → jwwang
Blocks: 1358399
Priority: -- → P3
Attachment #8860303 - Flags: review?(gsquelart)
Attachment #8860304 - Flags: review?(gsquelart)
Attachment #8860305 - Flags: review?(gsquelart)
Attachment #8860306 - Flags: review?(gsquelart)
Comment on attachment 8860303 [details]
Bug 1358401. P1 - reject the promise when failing to fetch the buffer.

https://reviewboard.mozilla.org/r/132330/#review135220
Attachment #8860303 - Flags: review?(gsquelart) → review+
Comment on attachment 8860304 [details]
Bug 1358401. P2 - use the 'once' handler to remove the |firstOpen| check.

https://reviewboard.mozilla.org/r/132332/#review135222
Attachment #8860304 - Flags: review?(gsquelart) → review+
Comment on attachment 8860305 [details]
Bug 1358401. P3 - reject the promise in LoadTest() when AppendTrack() fails.

https://reviewboard.mozilla.org/r/132334/#review135224
Attachment #8860305 - Flags: review?(gsquelart) → review+
Comment on attachment 8860306 [details]
Bug 1358401. P4 - reject the promise with an error string in UpdateSessionFunc().

https://reviewboard.mozilla.org/r/132336/#review135228
Attachment #8860306 - Flags: review?(gsquelart) → review+
Thanks for the review!
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8ecca35b9ae3
P1 - reject the promise when failing to fetch the buffer. r=gerald
https://hg.mozilla.org/integration/autoland/rev/cd4a2197143e
P2 - use the 'once' handler to remove the |firstOpen| check. r=gerald
https://hg.mozilla.org/integration/autoland/rev/02fb1ea3df4f
P3 - reject the promise in LoadTest() when AppendTrack() fails. r=gerald
https://hg.mozilla.org/integration/autoland/rev/f91f21db5c8e
P4 - reject the promise with an error string in UpdateSessionFunc(). r=gerald
You need to log in before you can comment on or make changes to this bug.