1358401 - Improve the error handling of eme.js

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P3)

Description

[JW Wang [:jwwang] [:jw_wang]]

Per bug 1358399 comment 0, we want to propagate the error to the client code which can finish the test and continue to run other tests to catch as many errors as possible in one test run.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1358401. P1 - reject the promise when failing to fetch the buffer.

Review commit: https://reviewboard.mozilla.org/r/132330/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/132330/

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1358401. P2 - use the 'once' handler to remove the |firstOpen| check.

Review commit: https://reviewboard.mozilla.org/r/132332/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/132332/

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1358401. P3 - reject the promise in LoadTest() when AppendTrack() fails.

Review commit: https://reviewboard.mozilla.org/r/132334/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/132334/

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1358401. P4 - reject the promise with an error string in UpdateSessionFunc().

Review commit: https://reviewboard.mozilla.org/r/132336/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/132336/

Comment 5

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8860303 [details]
Bug 1358401. P1 - reject the promise when failing to fetch the buffer.

https://reviewboard.mozilla.org/r/132330/#review135220

Comment 6

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8860304 [details]
Bug 1358401. P2 - use the 'once' handler to remove the |firstOpen| check.

https://reviewboard.mozilla.org/r/132332/#review135222

Comment 7

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8860305 [details]
Bug 1358401. P3 - reject the promise in LoadTest() when AppendTrack() fails.

https://reviewboard.mozilla.org/r/132334/#review135224

Comment 8

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8860306 [details]
Bug 1358401. P4 - reject the promise with an error string in UpdateSessionFunc().

https://reviewboard.mozilla.org/r/132336/#review135228

Comment 9

[JW Wang [:jwwang] [:jw_wang]]

Thanks for the review!

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8ecca35b9ae3
P1 - reject the promise when failing to fetch the buffer. r=gerald
https://hg.mozilla.org/integration/autoland/rev/cd4a2197143e
P2 - use the 'once' handler to remove the |firstOpen| check. r=gerald
https://hg.mozilla.org/integration/autoland/rev/02fb1ea3df4f
P3 - reject the promise in LoadTest() when AppendTrack() fails. r=gerald
https://hg.mozilla.org/integration/autoland/rev/f91f21db5c8e
P4 - reject the promise with an error string in UpdateSessionFunc(). r=gerald

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8ecca35b9ae3
https://hg.mozilla.org/mozilla-central/rev/cd4a2197143e
https://hg.mozilla.org/mozilla-central/rev/02fb1ea3df4f
https://hg.mozilla.org/mozilla-central/rev/f91f21db5c8e