Closed Bug 1358410 Opened 9 years ago Closed 9 years ago

Use StringBlobImpl in BlobSet and get rid of CX in AppendString() method

Categories

(Core :: DOM: Core & HTML, enhancement)

Product:
Core
Component:
DOM: Core & HTML
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla55
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: baku, Assigned: baku)

Details

Attachments

(2 files)

part 1 - stringBlobImpl
844 bytes, patch
qdot
: review+
Details | Diff | Splinter Review
part 2 - cx
4.98 KB, patch
qdot
: review+
Details | Diff | Splinter Review
With the first patch we avoid an extra allocation. The second patch is just the removal of a non-used variable.
Assignee: nobody → amarchesini
Attachment #8860295 - Flags: review?(kyle)
Attached patch part 2 - cx — — Splinter Review
Attachment #8860296 - Flags: review?(kyle)
Attachment #8860295 - Flags: review?(kyle) → review+
Attachment #8860296 - Flags: review?(kyle) → review+
Pushed by amarchesini@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/6a8d0cded18b Use StringBlobImpl in BlobSet, r=qdot https://hg.mozilla.org/integration/mozilla-inbound/rev/24f0f4caa031 Gt rid of CX parameter in BlobSet::AppendString(), r=qdot
https://hg.mozilla.org/mozilla-central/rev/6a8d0cded18b https://hg.mozilla.org/mozilla-central/rev/24f0f4caa031
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: