Closed Bug 1358421 Opened 7 years ago Closed 7 years ago

audio controls not visible after update from 52 to 53.0 (64-bits)

Categories

(Toolkit :: Video/Audio Controls, defect)

Product:
Toolkit
Component:
Video/Audio Controls
Version:
53 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1367846

People

(Reporter: luc.ooms, Unassigned)

References

(Blocks 1 open bug)

Details

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.81 Safari/537.36

Steps to reproduce:

did update from version 52 to 53.0


Actual results:

audio controls not visible, but can start audio by clicking on place where controls are supposed to be


Expected results:

controls should be visible
Found the cause.  The generated code for the audioplayer contained style="width: xxpx; height:30px".
In version 53 height must be at least 40px (or better omitted).  Otherwise the controls are not visible.
What audio controls? Can you please provide more context?
Flags: needinfo?(luc.ooms)
Component: Audio/Video → Audio/Video: Playback
(In reply to Jan-Ivar Bruaroey [:jib] from comment #2)
> What audio controls? Can you please provide more context?

See (the source code of) this link: http://www.e-lan.be/test/testaudio.htm
Flags: needinfo?(luc.ooms)
Yes, this bug is most frustrating.  Another minimal example:

Good: <audio controls style="height:40px"></audio>

Bad:  <audio controls style="height:39px"></audio>
Component: Audio/Video: Playback → Video/Audio Controls
Product: Core → Toolkit
Thanks for reporting, I'm on bug 1362146 which addressing the same issue.
See Also: → 1362146
Blocks: 1368639
Hi Luc,

As Bug 1373537 landed yesterday, the audio controls has shown on my latest nightly on Mac. Would you mind to help me to verify whether this problem is still or not? Thanks.
Flags: needinfo?(luc.ooms)
audio controls still invisible (Firefox 54.0.1 - Windows 10 (64 bits))
See http://www.e-lan.be/test/testaudio.htm
Flags: needinfo?(luc.ooms)
Duplicating this as the max-height issue has been verified as fixed in bug 1367846. Also I've tested the test case mentioned by Luc with latest m-c build, and it works fine.

Thanks Luc. Since it's too late to have a fix for 54, I'll try to uplift the patches to 55 if possible.
Status: UNCONFIRMED → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.