Closed Bug 1358431 Opened 3 years ago Closed 3 years ago
Add-on name bolded with delay in permissions pop-up
1.84 MB, application/zip
59 bytes, text/x-review-board-request
[Affected versions]: Firefox 55.0a1 (2017-04-20) [Affected platforms]: Windows 10 64-bit Ubuntu 16.04 32-bit [Steps to reproduce]: 1.Launch Firefox with a clean profile. 2.Install via drag&drop the attached webextension [Expected Results]: The add-on pop-up is displayed without any jerkiness or rendering issues. [Actual Results]: “More” word initially appears at the end of the first line https://www.screencast.com/t/wHaUbqb2lAR and only after that is displayed on the second line https://www.screencast.com/t/t3YkpEnA4 - this happens because the webextension name is bolded with delay. [Additional notes]: This issue was caught on Windows 10 64-bit. Mac and Ubuntu seems to not be visibly affected. [Regression Range]: Last good revision: 00c0bff27644aeba8eb96452874e21fc5c7cce65 First bad revision: 174e08cd1f55f0d271c836bd767823587da2cd59 Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=00c0bff27644aeba8eb96452874e21fc5c7cce65&tochange=174e08cd1f55f0d271c836bd767823587da2cd59 Looks like the following bug has the changes which introduced the regression: https://bugzilla.mozilla.org/show_bug.cgi?id=1329942
Mark, can you investigate how long the delay is/follow up with filer? discussion from bug 1329942
Assignee: nobody → mstriemer
See Also: → 1329942
Whiteboard: [permissions], investigating
I tried this on Windows, Mac and Linux now and it basically follows that order on how noticeable it is. Windows seems to have a wider bold font and a longer delay which makes it especially prominent. In my screen recording I was able to see two full frames with non-bold text then the wrapping would change when the bold is added. Quite noticeable. Mac doesn't seem to change the width much so it's hard to tell unless you're actively looking for it. Linux looks to me like there's no delay at all, or perhaps the fade in animation is a bit slower which allows for the repaint before the text is entirely visible. I think this is prominent enough on Windows that it should be fixed. I'm going to look at bug 1351255 which is for a similar dialog that will likely result in the same issue so hopefully I can come up with a good solution there and then update this to match.
Whiteboard: [permissions], investigating → [permissions]
Priority: -- → P2
Whiteboard: [permissions] → [permissions][triaged]
Andy, do you think this is possible to get done in the 55 window? (Not sure what P2 means for y'all).
See Also: → 1351255
After chatting to Mark, let's say "it's likely".
We're getting close to 55 going to beta, so I'll update 55 status to fix-optional, and we could still fix this early in beta if it doesn't happen this week.
These changes are based off of bug 1351255. @florian it would be nice to land this before the merge, if you have time to review it before then. Thanks!
Comment on attachment 8876294 [details] Bug 1358431 - Remove delay rendering add-on permissions popup header https://reviewboard.mozilla.org/r/147716/#review152088
Attachment #8876294 - Flags: review?(florian) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/2abb397e917c Remove delay rendering add-on permissions popup header r=florian
Please request Beta approval on this when you get a chance.
Comment on attachment 8876294 [details] Bug 1358431 - Remove delay rendering add-on permissions popup header Approval Request Comment [Feature/Bug causing the regression]: bug 1329942 [User impact if declined]: When installing an extension on Windows the dialog will shift around when being created. [Is this code covered by automated tests?]: No [Has the fix been verified in Nightly?]: No [Needs manual test from QE? If yes, steps to reproduce]: 1. Go to https://addons.mozilla.org/en-US/firefox/addon/screenshot-capture-annotate/ or any webextension add-on with permissions. 2. Click "Add to Firefox". 3. Watch for the confirm permissions popup to appear. 4. As it appears, it should always have the add-on name bolded in the header and should not change in size. * The bug (add-on name appears non-bold then switches to bold and resizes popup) was most noticeable on Windows. [List of other uplifts needed for the feature/fix]: None [Is the change risky?]: No [Why is the change risky/not risky?]: It is reverting the header rendering code to the pre-regression version and using a CSS fix instead. [String changes made/needed]: No
Attachment #8876294 - Flags: approval-mozilla-beta?
Comment on attachment 8876294 [details] Bug 1358431 - Remove delay rendering add-on permissions popup header fix for add-on permissions popup regression, beta55+ should be in 55.0b2
Attachment #8876294 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
I was able to reproduce the initial issue on Firefox 55.0a1 (2017-04-21) under Windows 10 64-bit. Verified as fixed on Firefox 56.0a1 (2017-06-15) and Firefox 55.0b2 (20170615063713) under Windows 10 64-bit, Ubuntu 16.04 32-bit and Mac OS X 10.12.1. The webextension name is no longer bolded with delay: https://www.screencast.com/t/ev98sgtWB0
You need to log in before you can comment on or make changes to this bug.