1358432 - [Regression]'Add to Bookmarks' share extension does not work on v7.3b2756

Status: VERIFIED FIXED

(Firefox for iOS :: General, enhancement)

Description

[Catalin Suciu [:csuciu]]

v7.3b2756

1. Visit a site
2. Open Share menu and select => Firefox => Add to Bookmarks => Add
3. Check Bookmarks panel

Result: The site doesn't show up in the bookmarks list.

Note: This issue is not reproducible on v7.2 (release)

Comment 1

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Attachment: Debug log from ShareTo

Comment 2

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

The problem is as follows: insertBookmark(_:title:favicon:intoFolder:withTitle:) is an asynchronous function. It returns a Deferred. But that deferred gets lost in profile.shareItem() and is ignore. So the ShareTo app extension finishes and then closes the database connection too soon.

Comment 3

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Attachment: PR https://github.com/mozilla-mobile/firefox-ios/pull/2651

This patch makes `shareItem` return a `Success` (which is a `Deferred<Maybe<Void>>`) so that the caller can wait for asynchronous database operations to finish. Currently we just call `shareItem()` and then immediately `profile.shutdown()`, which is bad since we are still in the process of adding the bookmark. This patch makes it possible to properly wait.

Comment 4

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Landed on both v7.x and master

Comment 5

[Catalin Suciu [:csuciu]]

Verifying as fixed in 7.3 (2772) release