Remove the layout.css.float-logical-values.enabled pref, so that the logical values are unconditionally supported

RESOLVED FIXED in Firefox 61

Status

()

Core
CSS Parsing and Computation
P3
normal
RESOLVED FIXED
a year ago
3 months ago

People

(Reporter: jfkthame, Assigned: jfkthame)

Tracking

unspecified
mozilla61
Points:
---

Firefox Tracking Flags

(firefox61 fixed)

Details

Attachments

(2 attachments)

(Assignee)

Description

a year ago
Bug 1253919 will make this pref default to 'true' everywhere. Once that is safely shipped, we should clean up the codebase by removing the pref altogether.

(IMO, it's highly unlikely that enabling the values on release will result in any web-compat issues, but nevertheless, a two-stage approach where we first flip the pref in one release and then remove it a release or two later seems like the safest approach.)
(Assignee)

Comment 1

a year ago
Created attachment 8860356 [details] [diff] [review]
Remove the layout.css.float-logical-values.enabled pref, now that we support the logical values everywhere

Patch to remove the pref, to land once we're really sure we don't need to revert it for any reason.
(Assignee)

Updated

a year ago
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
Jonathan, should we get this patched reviewed and landed now?
Flags: needinfo?(jfkthame)
Priority: -- → P3
(Assignee)

Comment 3

3 months ago
Yes, I can't see us turning the clock back now.

(I'm sure the patch will need a refresh in order to be landable.)
Flags: needinfo?(jfkthame)
(Assignee)

Comment 4

3 months ago
Created attachment 8968858 [details] [diff] [review]
Remove the layout.css.float-logical-values.enabled pref, now that we support the logical values everywhere
Attachment #8968858 - Flags: review?(cam)
Comment on attachment 8968858 [details] [diff] [review]
Remove the layout.css.float-logical-values.enabled pref, now that we support the logical values everywhere

Review of attachment 8968858 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.  Note that this pref already has no effect, since we don't check it in the Servo float/clear parsing code.
Attachment #8968858 - Flags: review?(cam) → review+

Comment 6

3 months ago
Pushed by jkew@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2142864c9ba4
Remove the layout.css.float-logical-values.enabled pref, now that we support the logical values everywhere. r=heycam

Comment 7

3 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/2142864c9ba4
Status: ASSIGNED → RESOLVED
Last Resolved: 3 months ago
status-firefox61: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.