Closed Bug 1358450 Opened 3 years ago Closed 2 years ago

Remove the layout.css.float-logical-values.enabled pref, so that the logical values are unconditionally supported

Categories

(Core :: CSS Parsing and Computation, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: jfkthame, Assigned: jfkthame)

References

Details

Attachments

(2 files)

Bug 1253919 will make this pref default to 'true' everywhere. Once that is safely shipped, we should clean up the codebase by removing the pref altogether.

(IMO, it's highly unlikely that enabling the values on release will result in any web-compat issues, but nevertheless, a two-stage approach where we first flip the pref in one release and then remove it a release or two later seems like the safest approach.)
Patch to remove the pref, to land once we're really sure we don't need to revert it for any reason.
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
Jonathan, should we get this patched reviewed and landed now?
Flags: needinfo?(jfkthame)
Priority: -- → P3
Yes, I can't see us turning the clock back now.

(I'm sure the patch will need a refresh in order to be landable.)
Flags: needinfo?(jfkthame)
Comment on attachment 8968858 [details] [diff] [review]
Remove the layout.css.float-logical-values.enabled pref, now that we support the logical values everywhere

Review of attachment 8968858 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.  Note that this pref already has no effect, since we don't check it in the Servo float/clear parsing code.
Attachment #8968858 - Flags: review?(cam) → review+
Pushed by jkew@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2142864c9ba4
Remove the layout.css.float-logical-values.enabled pref, now that we support the logical values everywhere. r=heycam
https://hg.mozilla.org/mozilla-central/rev/2142864c9ba4
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.