Closed
Bug 1358450
Opened 7 years ago
Closed 6 years ago
Remove the layout.css.float-logical-values.enabled pref, so that the logical values are unconditionally supported
Categories
(Core :: CSS Parsing and Computation, enhancement, P3)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: jfkthame, Assigned: jfkthame)
References
Details
Attachments
(2 files)
14.24 KB,
patch
|
Details | Diff | Splinter Review | |
14.84 KB,
patch
|
heycam
:
review+
|
Details | Diff | Splinter Review |
Bug 1253919 will make this pref default to 'true' everywhere. Once that is safely shipped, we should clean up the codebase by removing the pref altogether. (IMO, it's highly unlikely that enabling the values on release will result in any web-compat issues, but nevertheless, a two-stage approach where we first flip the pref in one release and then remove it a release or two later seems like the safest approach.)
Assignee | ||
Comment 1•7 years ago
|
||
Patch to remove the pref, to land once we're really sure we don't need to revert it for any reason.
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
Comment 2•6 years ago
|
||
Jonathan, should we get this patched reviewed and landed now?
Flags: needinfo?(jfkthame)
Updated•6 years ago
|
Priority: -- → P3
Assignee | ||
Comment 3•6 years ago
|
||
Yes, I can't see us turning the clock back now. (I'm sure the patch will need a refresh in order to be landable.)
Flags: needinfo?(jfkthame)
Assignee | ||
Comment 4•6 years ago
|
||
Attachment #8968858 -
Flags: review?(cam)
Comment 5•6 years ago
|
||
Comment on attachment 8968858 [details] [diff] [review] Remove the layout.css.float-logical-values.enabled pref, now that we support the logical values everywhere Review of attachment 8968858 [details] [diff] [review]: ----------------------------------------------------------------- Looks good. Note that this pref already has no effect, since we don't check it in the Servo float/clear parsing code.
Attachment #8968858 -
Flags: review?(cam) → review+
Pushed by jkew@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/2142864c9ba4 Remove the layout.css.float-logical-values.enabled pref, now that we support the logical values everywhere. r=heycam
Comment 7•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/2142864c9ba4
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•