Closed Bug 1358540 Opened 3 years ago Closed 3 years ago

Change the *.lint files to be *.lint.py to better support editor integration & flake8 linting

Categories

(Firefox Build System :: Lint and Formatting, enhancement)

3 Branch
enhancement
Not set

Tracking

(firefox55 fixed)

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(1 file)

I'm planning on some enhancements to the ESLint file. Currently due to the filename ending with .lint I loose the editor integration and flake8 linting.

Hence, even if these aren't ideal files (see bug 1288432), I'd like to change to .lint.py for now, to get the easy benefits of editor & flake8.
Assignee: nobody → standard8
Comment on attachment 8860489 [details]
Bug 1358540 - Change the *.lint files to be *.lint.py to better support editor integration & flake8 linting.

https://reviewboard.mozilla.org/r/132488/#review135922

Seems mostly harmless to me...

::: python/mozlint/mozlint/cli.py:89
(Diff revision 1)
>          if not os.path.isdir(search_path):
>              continue
>  
>          files = os.listdir(search_path)
>          for f in files:
> -            name, ext = os.path.splitext(f)
> +            path, name = os.path.split(f)

`name = os.path.basename(f)`
Attachment #8860489 - Flags: review?(smacleod) → review+
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/eec770d062b4
Change the *.lint files to be *.lint.py to better support editor integration & flake8 linting. r=smacleod
Backout by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4653b1d21e87
Backed out changeset eec770d062b4 for bustage
Apparently I missed renaming the test files, which I've now fixed. Will push to try before re-pushing to autoland.
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6c67c4f0bf30
Change the *.lint files to be *.lint.py to better support editor integration & flake8 linting. r=smacleod
https://hg.mozilla.org/mozilla-central/rev/6c67c4f0bf30
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Product: Testing → Firefox Build System
Version: Version 3 → 3 Branch
You need to log in before you can comment on or make changes to this bug.