1358552 - Incorrect js-ctypes ABI specifications for Win32 APIs in toolkit

Status: RESOLVED FIXED

(Toolkit :: General, defect)

Description

[(No longer employed by Mozilla) Aaron Klotz]

This is bad. On 32-bit Windows, the *callee* pops parameters off the stack, whereas ctypes.default_abi assumes that the *caller* pops parameters off the stack. We should be using ctypes.winapi_abi whenever MSDN shows that the function uses the WINAPI calling convention.

Comment 1

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Bug 1358552: Fix incorrect ABI specification in js-ctypes declarations in toolkit;

Review commit: https://reviewboard.mozilla.org/r/133532/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/133532/

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 8861566 [details]
Bug 1358552: Fix incorrect ABI specification in js-ctypes declarations in toolkit;

https://reviewboard.mozilla.org/r/133532/#review136418

Doh.  Please ask for uplift on all appropriate branches.  I think we want this on esr52 as well.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ed5093d44121
Fix incorrect ABI specification in js-ctypes declarations in toolkit; r=froydnj

Comment 4

[(No longer employed by Mozilla) Aaron Klotz]

Comment on attachment 8861566 [details]
Bug 1358552: Fix incorrect ABI specification in js-ctypes declarations in toolkit;

Approval Request Comment
[Feature/Bug causing the regression]: JS-ctypes code in toolkit
[User impact if declined]: Potential for crashes and/or data corruption
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Trivial patch
[String changes made/needed]: None

Comment 5

[(No longer employed by Mozilla) Aaron Klotz]

Comment on attachment 8861566 [details]
Bug 1358552: Fix incorrect ABI specification in js-ctypes declarations in toolkit;

[Approval Request Comment]
If this is not a sec:{high,crit} bug, please state case for ESR consideration: This is a stability issue
User impact if declined: Potential for crashing / data corruption
Fix Landed on Version: 55, 54 requested
Risk to taking this patch (and alternatives if risky): None. Trivial patch
String or UUID changes made by this patch: None

See https://wiki.mozilla.org/Release_Management/ESR_Landing_Process for more info.

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ed5093d44121

Comment 7

[Gerry Chang [:gchang]]

Comment on attachment 8861566 [details]
Bug 1358552: Fix incorrect ABI specification in js-ctypes declarations in toolkit;

Fix a potential crash/data corruption. Beta54+. Should be in 54 beta 3.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/f4279077d48f

Comment 9

[(No longer employed by Mozilla) Aaron Klotz]

Comment on attachment 8861566 [details]
Bug 1358552: Fix incorrect ABI specification in js-ctypes declarations in toolkit;

Cancelling ESR52 request. I have looked at the libffi code and there is no chance of crashing given the way it is implemented.

Comment 10

[Andrei Vaida [:avaida]]

(In reply to Aaron Klotz [:aklotz] (a11y work receiving priority right now) from comment #4)
> [Is this code covered by automated tests?]: Yes
> [Has the fix been verified in Nightly?]: Yes
> [Needs manual test from QE? If yes, steps to reproduce]: No

Setting qe-verify- based on Aaron's assessment on manual testing needs and the fact that this fix has automated coverage.