Closed Bug 1358554 Opened 6 years ago Closed 6 years ago

Long pressing on devices using fixed action bar can cause the content to slide down.

Categories

(GeckoView :: General, defect)

Product:
GeckoView
Component:
General
Platform:
Unspecified
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox55 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla55
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: rbarker, Assigned: rbarker)

References

Details

Attachments

(1 file)

Bug 1358554 - On Android devices that use static action bar prevent content from sliding down after a long press
59 bytes, text/x-review-board-request
jchen
: review+
Details 
On Android devices using the fixed action bar, long pressing when the toolbar is hidden will cause the content to shift down under the users finger when the action bar is displayed.
Assignee: nobody → rbarker
Depends on: dynamic-toolbar-3
Comment on attachment 8860503 [details]
Bug 1358554 - On Android devices that use static action bar prevent content from sliding down after a long press

https://reviewboard.mozilla.org/r/132510/#review135948

::: mobile/android/base/java/org/mozilla/gecko/BrowserApp.java:263
(Diff revision 2)
>      public static final String TAB_HISTORY_FRAGMENT_TAG = "tabHistoryFragment";
>  
> +    // When the static action bar is shown, only the real toolbar chrome should be
> +    // shown when the toolbar is visible. Causing the toolbar animator to also
> +    // show the snapshot causes the content to shift under the users finger.
> +    // See: Bug 1340301

Wrong bug?
Attachment #8860503 - Flags: review?(nchen) → review+
(In reply to Jim Chen [:jchen] [:darchons] from comment #3)
> Comment on attachment 8860503 [details]
> Bug 1358554 - Long pressing on devices using fixed action bar can cause the
> content to slide down
> 
> https://reviewboard.mozilla.org/r/132510/#review135948
> 
> ::: mobile/android/base/java/org/mozilla/gecko/BrowserApp.java:263
> (Diff revision 2)
> >      public static final String TAB_HISTORY_FRAGMENT_TAG = "tabHistoryFragment";
> >  
> > +    // When the static action bar is shown, only the real toolbar chrome should be
> > +    // shown when the toolbar is visible. Causing the toolbar animator to also
> > +    // show the snapshot causes the content to shift under the users finger.
> > +    // See: Bug 1340301
> 
> Wrong bug?

YES! Thanks for catching that.
Pushed by rbarker@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/127620ed468a
On Android devices that use static action bar prevent content from sliding down after a long press r=jchen
https://hg.mozilla.org/mozilla-central/rev/127620ed468a
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Product: Firefox for Android → GeckoView
Target Milestone: Firefox 55 → mozilla55
You need to log in before you can comment on or make changes to this bug.