Closed Bug 1358586 Opened 4 years ago Closed 4 years ago

Gecko incorrectly accepts -webkit-linear-gradient expressions without a comma after the angle

Categories

(Core :: CSS Parsing and Computation, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: dholbert, Assigned: dholbert)

References

Details

Attachments

(1 file)

We seem to accept -webkit-linear-gradient values with "angle" syntax *without a comma* after the angle.

For example, we honor the following (and paint a gradient in all cases):
data:text/html,<div style="background:-webkit-linear-gradient(135deg red, blue)">Hi

data:text/html,<div style="background:-webkit-linear-gradient(0deg red, blue)">Hi

data:text/html,<div style="background:-webkit-linear-gradient(0 red, blue)">Hi


...but Chrome does not honor those.  If I add a comma after the angle, they do accept it though.

So, we should treat the comma as mandatory here, and we need to update property_database.js accordingly to make http://searchfox.org/mozilla-central/rev/7aa21f3b531ddee90a353215bd86e97d6974e25b/layout/style/test/property_database.js#715 "invalid" instead of "valid" (and add a few similar invalid examples with "deg" units as well).
Blocks: 1356087
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Comment on attachment 8860545 [details]
Bug 1358586: Require comma after <angle>, in -webkit-linear-gradient() CSS syntax.

https://reviewboard.mozilla.org/r/132536/#review135474
Attachment #8860545 - Flags: review?(cam) → review+
Pushed by dholbert@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a9c09e578cf3
Require comma after <angle>, in -webkit-linear-gradient() CSS syntax. r=heycam
Pushed by kwierso@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/a95c42f6d33f
Adjust stylo expectation data a=me
Pushed by kwierso@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/69364e8ccec5
Fix adjusted stylo expectation data a=me
Depends on: 1359792
No longer depends on: 1359792
You need to log in before you can comment on or make changes to this bug.