|Submitter||Diff||Changes||Open Issues||Last Updated|
|Error loading review requests:|
We sometimes want to ship a newer cargo than the one from the rust release we're using. Add a switch to the repack script to make this easier.
Comment on attachment 8860498 [details] Bug 1358590 - Update rust-build to v0.4.5. https://reviewboard.mozilla.org/r/132502/#review135372 Thanks! ::: taskcluster/docker/rust-build/repack_rust.py:119 (Diff revision 1) > req.raise_for_status() > manifest = toml.loads(req.content) > if manifest['manifest-version'] != '2': > log('ERROR: unrecognized manifest version %s.' % > manifest['manifest-version']) > - return > + return None This should probably just `raise` since nothing seems to handle this case anyway. ::: taskcluster/docker/rust-build/repack_rust.py:231 (Diff revision 1) > - return 'stable' > > if __name__ == '__main__': > - channel = args() > - repack(mac64, [mac64, mac32], channel=channel) > - repack(win32, [win32], channel=channel) > + args = args() > + repack(mac64, [mac64], > + channel=args.channel, cargo_channel=args.cargo_channel) You can shorten this a little by doing `args = vars(args())` and then calling `repack(x, [x], **args)` to turn `args` into a dict and pass it as `kwargs`.
Thanks. I thought about passing the channels as a group but didn't realize that wouldn't clobber the `suffix` value. I'll update the script and also fix the flake8 lints.
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/81a606f52360 Update rust-build to v0.4.5. r=ted