Closed Bug 1358597 Opened 3 years ago Closed 3 years ago

always make Cargo verbose in automation

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set

Tracking

(firefox55 fixed)

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: froydnj, Assigned: froydnj)

Details

Attachments

(1 file)

This change brings Cargo closer to what our C/C++ build already does,
and some forms of Cargo failure are only diagnosed when you pass
`--verbose`, so let's eliminate that extra step for people.
As discussed on IRC, and overly verbose because of Make's marvelous syntax.
Attachment #8860505 - Flags: review?(ted)
Comment on attachment 8860505 [details] [diff] [review]
always make Cargo verbose in automation

Review of attachment 8860505 [details] [diff] [review]:
-----------------------------------------------------------------

We could also fiddle things around so that `MOZ_AUTOMATION` sets `BUILD_VERBOSE_LOG` in configure, but I'm not terribly fussed about it.

Good call, thanks for fixing this!
Attachment #8860505 - Flags: review?(ted) → review+
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ff6efb59ef86
always make Cargo verbose in automation; r=ted.mielczarek
https://hg.mozilla.org/mozilla-central/rev/ff6efb59ef86
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.