unified build bustage due to PUiCompositorController.ipdl changes

RESOLVED FIXED in Firefox 55

Status

()

Firefox for Android
GeckoView
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: bkelly, Assigned: bkelly)

Tracking

unspecified
Firefox 55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

a year ago
I have a work in progress patch that adds some IPC actors.  With my patch applied I get all kinds of errors like this on today's m-c:

     0:26.11 In file included from /srv/mozilla-central/obj-x86_64-pc-linux-gnu-optdebug/dist/include/ip
    c/IPCMessageUtils.h:11:0,
     0:26.11                  from /srv/mozilla-central/obj-x86_64-pc-linux-gnu-optdebug/ipc/ipdl/_ipdlheaders/mozilla/net/PTransportProvider.h:11,
     0:26.11                  from /srv/mozilla-central/obj-x86_64-pc-linux-gnu-optdebug/ipc/ipdl/PTransportProvider.cpp:7,
     0:26.11                  from /srv/mozilla-central/obj-x86_64-pc-linux-gnu-optdebug/ipc/ipdl/UnifiedProtocols24.cpp:2:
     0:26.12 /srv/mozilla-central/ipc/chromium/src/chrome/common/ipc_message_utils.h: In instantiation of ‘void IPC::WriteParam(IPC::Message*, const P&) [with P = mozilla::gfx::IntSizeTyped<mozilla::ScreenPixel>]’:
     0:26.12 /srv/mozilla-central/obj-x86_64-pc-linux-gnu-optdebug/ipc/ipdl/_ipdlheaders/mozilla/layers/PUiCompositorControllerChild.h:172:24:   required from ‘void mozilla::layers::PUiCompositorControllerChild::Write(const T&, mozilla::layers::PUiCompositorControllerChild::Message*) [with T = mozilla::gfx::IntSizeTyped<mozilla::ScreenPixel>; mozilla::layers::PUiCompositorControllerChild::Message = IPC::Message]’
     0:26.12 /srv/mozilla-central/obj-x86_64-pc-linux-gnu-optdebug/ipc/ipdl/PUiCompositorControllerChild.cpp:329:23:   required from here
     0:26.12 /srv/mozilla-central/ipc/chromium/src/chrome/common/ipc_message_utils.h:111:24: error: ‘Write’ is not a member of ‘IPC::ParamTraits<mozilla::gfx::IntSizeTyped<mozilla::ScreenPixel> >’
     0:26.12    ParamTraits<P>::Write(m, p);
     0:26.12                         ^
     0:26.12 /srv/mozilla-central/ipc/chromium/src/chrome/common/ipc_message_utils.h: In instantiation of ‘bool IPC::ReadParam(const IPC::Message*, PickleIterator*, P*) [with P = mozilla::gfx::PointTyped<mozilla::ScreenPixel>]’:
     0:26.12 /srv/mozilla-central/obj-x86_64-pc-linux-gnu-optdebug/ipc/ipdl/_ipdlheaders/mozilla/layers/PUiCompositorControllerChild.h:182:30:   required from ‘bool mozilla::layers::PUiCompositorControllerChild::Read(T*, const Message*, PickleIterator*) [with T = mozilla::gfx::PointTyped<mozilla::ScreenPixel>; mozilla::layers::PUiCompositorControllerChild::Message = IPC::Message]’
     0:26.12 /srv/mozilla-central/obj-x86_64-pc-linux-gnu-optdebug/ipc/ipdl/PUiCompositorControllerChild.cpp:408:68:   required from here
     0:26.12 /srv/mozilla-central/ipc/chromium/src/chrome/common/ipc_message_utils.h:117:30: error: ‘Read’ is not a member of ‘IPC::ParamTraits<mozilla::gfx::PointTyped<mozilla::ScreenPixel> >’
     0:26.12    return ParamTraits<P>::Read(m, iter, p);
     0:26.12                               ^
     0:26.12 /srv/mozilla-central/ipc/chromium/src/chrome/common/ipc_message_utils.h: In instantiation of ‘bool IPC::ReadParam(const IPC::Message*, PickleIterator*, P*) [with P = mozilla::gfx::ScaleFactor<mozilla::CSSPixel, mozilla::ScreenPixel>]’:
     0:26.12 /srv/mozilla-central/obj-x86_64-pc-linux-gnu-optdebug/ipc/ipdl/_ipdlheaders/mozilla/layers/PUiCompositorControllerChild.h:182:30:   required from ‘bool mozilla::layers::PUiCompositorControllerChild::Read(T*, const Message*, PickleIterator*) [with T = mozilla::gfx::ScaleFactor<mozilla::CSSPixel, mozilla::ScreenPixel>; mozilla::layers::PUiCompositorControllerChild::Message = IPC::Message]’
     0:26.12 /srv/mozilla-central/obj-x86_64-pc-linux-gnu-optdebug/ipc/ipdl/PUiCompositorControllerChild.cpp:417:60:   required from here
     0:26.12 /srv/mozilla-central/ipc/chromium/src/chrome/common/ipc_message_utils.h:117:30: error: ‘Read’ is not a member of ‘IPC::ParamTraits<mozilla::gfx::ScaleFactor<mozilla::CSSPixel, mozilla::ScreenPixel> >’ 

As far as I can tell PUiCompositorController.ipdl is depending on getting GfxMessageUtils.h via the unified build.  It should include it directly instead.
(Assignee)

Comment 1

a year ago
Created attachment 8860526 [details] [diff] [review]
Fix unified build bustage in PUiCompositorController.ipdl.  r=kats

Thanks for the help figuring this out!
Attachment #8860526 - Flags: review?(bugmail)
(Assignee)

Updated

a year ago
Blocks: 1293277
Attachment #8860526 - Flags: review?(bugmail) → review+

Comment 2

a year ago
Pushed by bkelly@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/44ffc0867fbb
Fix unified build bustage in PUiCompositorController.ipdl.  r=kats
https://hg.mozilla.org/mozilla-central/rev/44ffc0867fbb
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
You need to log in before you can comment on or make changes to this bug.