Closed Bug 1358697 Opened 3 years ago Closed 3 years ago

MessageChannel::Send captures raw pointer of Refcounted type

Categories

(Core :: IPC, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: kanru, Unassigned)

References

Details

Attachments

(1 file)

Sotaro found this when trying to use MozPromise in his patch, https://bugzilla.mozilla.org/show_bug.cgi?id=1313200#c54
Blocks: 1358014
Comment on attachment 8860592 [details]
Bug 1358697 - Don't capture the Promise raw pointer and make static analysis happy.

https://reviewboard.mozilla.org/r/132602/#review135866
Attachment #8860592 - Flags: review?(wmccloskey) → review+
Pushed by kchen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2f0e513820c0
Don't capture the Promise raw pointer and make static analysis happy. r=billm
Backout by ihsiao@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1b60cc98d34f
Backed out changeset 2f0e513820c0 for build bustage
Pushed by kchen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8aceb515532c
Don't capture the Promise raw pointer and make static analysis happy. r=billm
Flags: needinfo?(kchen)
https://hg.mozilla.org/mozilla-central/rev/8aceb515532c
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.