1358750 - Port Bug 1224528 [Provide a mechanism to populate the OneCRL kinto collection with initial records] to SeaMonkey

Status: RESOLVED FIXED

(SeaMonkey :: Passwords & Permissions, enhancement)

Description

[Frank-Rainer Grahl (:frg)]

+++ This bug was initially created as a clone of Bug #1224528 +++

It would be desirable if the kinto version of the OneCRL Certificate blocklist did not need to fetch initial data from the kinto server.

The blocklist.xml used by the AMO version of OneCRL is shipped with products; we need a similar mechanism which allows initial versions to be read from a user's profile.

Comment 1

[Frank-Rainer Grahl (:frg)]

Attachment: Capture.PNG

Error message shown in a new profile at least. The screenshot is from TB Daily but its the same for SeaMonkey.

Comment 2

[Frank-Rainer Grahl (:frg)]

Attachment: 1358750-blocklist.patch

[Approval Request Comment]
Regression caused by (bug #): 1224528
User impact if declined: More network traffic during startup. The blocklists will be populated over time.
Testing completed (on m-c, etc.): c-c and c-a
Risk to taking this patch (and alternatives if risky): none
String changes made by this patch: none

Comment 3

[Frank-Rainer Grahl (:frg)]

Attachment: 1358750-blocklist-tb.patch

Jorg, I think this patch would fix it for TB but I didn't test it yet.

Comment 4

[Jorg K (CEST = GMT+2)]

Thanks, somewhat unrelated, this went past recently:
https://hg.mozilla.org/mozilla-central/rev/4266cb39733d
Should we port that?

Comment 5

[Frank-Rainer Grahl (:frg)]

>> Thanks, somewhat unrelated, this went past recently:

Have it already in my SeaMonkey since Tuesday and seems to work. Was backed out the first time in m-i because of test issues I think. Now that its back should be safe to put it in. SeaMonkey currently doesn't have it enabled see bug 1305902 but this might change and I prefer the SeaMonkey installer to be as close as possible to FF. I will put up a separate bug.

Comment 6

[Ian Neal]

Comment on attachment 8860607 [details] [diff] [review]
1358750-blocklist.patch

LGTM r/a=me

Comment 7

[Jorg K (CEST = GMT+2)]

Comment on attachment 8860613 [details] [diff] [review]
1358750-blocklist-tb.patch

We'll have it too ;-)

Comment 8

[Frank-Rainer Grahl (:frg)]

https://hg.mozilla.org/comm-central/rev/aabacca9d82e433501491cbaec6221044a331ef1
https://hg.mozilla.org/releases/comm-beta/rev/20077fa45f4fb6d5bd1932c14b7b33dbbfc2e593

https://hg.mozilla.org/comm-central/rev/3ac9b030d8e6020182d35cc201ae1011a5382afe

If you want it in TB beta just let me know.