1358772 - Delete passwords - if the master password is set

Status: RESOLVED WORKSFORME

(Toolkit :: Data Sanitization, defect, P5)

Description

[janekptacijarabaci]

User Agent: Opera/9.80 (Windows NT 6.1; WOW64) Presto/2.12.388 Version/12.18

Steps to reproduce:

If the master password is set:
1) Use function "Forget About Site"
2) At the prompt (Master Password), press Cancel




Actual results:

Throws an error in Browser Console:

Exception occured in clearing passwords : ...
There were a total of 1 errors during removal



Expected results:

Browser Console should be empty.

The indexOf() method is case sensitive.
User canceled Master Password entry  !==  User canceled master password entry

See:
https://hg.mozilla.org/mozilla-central/file/0acbd98f996d/toolkit/forgetaboutsite/ForgetAboutSite.jsm#l133

Comment 1

[Harshit Sohaney [:hsohaney]]

This doesn't look reproducible anymore, looks like the code was refactored and moved into a separate passwords cleaner https://searchfox.org/mozilla-central/source/toolkit/components/cleardata/ClearDataService.sys.mjs#576
Can we close this?

Comment 2

[Emma Zühlcke [:emz]]

If it can't be reproduced anymore feel free to close the bug as WORKSFORME. Where is that error message thrown anyway?

Comment 3

[Harshit Sohaney [:hsohaney]]

It's supposed to throw if an exception occurs when clearing passwords now. I was unable to reproduce it on MacOS with the new clearing mechanisms.