Closed Bug 1358828 Opened 3 years ago Closed 3 years ago

Various bits of cleanup related to VectorImage painting

Categories

(Core :: SVG, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
Tracking Status
firefox55 --- affected

People

(Reporter: jwatt, Assigned: jwatt)

References

Details

Attachments

(4 files)

I need this for a later patch.
Attachment #8860694 - Flags: review?(longsonr)
Attachment #8860694 - Flags: review?(longsonr) → review+
Attachment #8860696 - Flags: review?(longsonr) → review+
Pushed by jwatt@jwatt.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a06749566178
part 1 - Add some missing includes. r=longsonr
https://hg.mozilla.org/integration/mozilla-inbound/rev/97af1ab68078
part 2 - Avoid setting state on SVG images if we use an image from the surface cache. r=longsonr
Keywords: leave-open
Attachment #8861036 - Attachment is patch: true
I overlooked one other place where we set preserveAspectRatio on SVGImageContext, which is in nsSVGImageFrame. I'm not sure quite how/if to deal with that, but I still want to land part 3 in order to clear some ground to use the split out AutoPreserveAspectRatioOverride in bug 1353771.
Attachment #8861036 - Flags: review?(longsonr) → review+
Pushed by jwatt@jwatt.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/72f0302be66e
part 3 - Split AutoSVGRenderingState into two separate classes. r=longsonr
I guess I'm not going to do part 4, so let's call this done.
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Summary: Stop using SVGImageContext to store/pass preserveAspectRatio override information → Various bits of cleanup related to VectorImage painting
(In reply to Pulsebot from comment #7)
> Pushed by jwatt@jwatt.org:
> https://hg.mozilla.org/integration/mozilla-inbound/rev/72f0302be66e
> part 3 - Split AutoSVGRenderingState into two separate classes. r=longsonr

I think one effect of this is to cause
AutoPreserveAspectRatioOverride::mDidOverride to be used on all paths in the
destructor, but only to be set on some paths in the constructor.  In other
words, the destructor use may use it uninitialised.
Flags: needinfo?(longsonr)
Blocks: 1364179
Flags: needinfo?(longsonr)
Removing leave-open keyword from resolved bugs, per :sylvestre.
Keywords: leave-open
You need to log in before you can comment on or make changes to this bug.