Closed Bug 1358837 Opened 7 years ago Closed 6 years ago

reenable native Linux notifications by default (disabled by bug 1144693 in version 40)

Categories

(Thunderbird :: Preferences, defect)

Product:
Thunderbird
Component:
Preferences
Version:
45 Branch
Platform:
All
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(thunderbird_esr52 wontfix, thunderbird_esr60 fixed, thunderbird60 fixed, thunderbird61 wontfix, thunderbird62 fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 62.0
Tracking Flags:
Tracking Status
thunderbird_esr52 --- wontfix
thunderbird_esr60 --- fixed
thunderbird60 --- fixed
thunderbird61 --- wontfix
thunderbird62 --- fixed

People

(Reporter: t6zm3v62fkp7fe5, Assigned: jorgk-bmo)

References

Details

Attachments

(3 files)

thunderbird-preferences-lubuntu.png
66.07 KB, image/png
Details
transmission-notifications-lubuntu.png
212.88 KB, image/png
Details
1358837-native-linux-notification.patch
899 bytes, patch
mkmelin
: review+
jorgk-bmo
: approval-comm-beta+
jorgk-bmo
: approval-comm-esr60+
Details | Diff | Splinter Review 
User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Ubuntu Chromium/57.0.2987.98 Chrome/57.0.2987.98 Safari/537.36



Actual results:

There is no visual notifications in Thunderbird on Lubuntu, only sound. The option that is related to them "Show an alert" just doesn't work (screenshot is attached).
By the way, many programs use it, like Transmission etc (screenshot is attached).
Lubuntu 16.04 x64, Thunderbird 45.8.0 from Ubuntu repos.

    
  
Severity: normal → enhancement
OS: Unspecified → Linux
Hardware: Unspecified → All

    
    

    
  
There is a hidden preference to activate libnotify on Linux, that's mail.biff.use_system_alert (defaults to false, toggle to true in [≡] > Preferences > Advanced > General > Config Editor).

It was enabled at some point but libnotify messages didn't work in many cases, thus it was disabled again by bug 1144693 and that preference setting introduced by bug 1144719.

    
    

    
  
Ok, I may be missing the point of this bug here given that the add-on works on platforms other than Linux as well. So, what exactly is it adding over the regular libnotify messages?

    
    

    
  
rsx11m: thank you for mentioning the hidden preference! I enabled it and it's working sufficiently for me on Solus Budgie Linux.

The difference to the add-on is that the add-on adds three buttons to the notification:

1. Open
2. Mark as read
3. Delete

Personally, I don't need those buttons and will just continue to use the preference without the add-on.

    
    

    
  
By the way, we should strive for enabling the preference by default. Not having native notifications, in this case on Linux, is a negative user experience.

    
    

    
  
Not having any notifications at all is a problem as well, thus re-enabling this feature by default has to depend on bug 1152773 and bug 1162788 being fixed first.

    
    

    
  
(In reply to rsx11m from comment #8)
> Not having any notifications at all is a problem as well, thus re-enabling
> this feature by default has to depend on bug 1152773 and bug 1162788 being
> fixed first.

So this bug is a duplicate, and not an enhancement?
Flags: needinfo?(rsx11m.pub)

    
    

    
  
Well, we can consider this a follow-up bug to switch the pref on again once all dependencies are fixed.
Flags: needinfo?(rsx11m.pub)

    
  
Severity: enhancement → normal
Status: UNCONFIRMED → NEW
Component: Untriaged → Preferences
Depends on: 1152773, 1144693
Ever confirmed: true
Summary: Add native Linux notifications to Thunderbird → reenable native Linux notifications by default

    
  
Depends on: 1162788

    
    

    
  
Are there any remaining issues that are blocking this enhancement? I have commented on the open dependencies and just wanted to mention I haven't had a problem with `mail.biff.use_system_alert` enabled for some time now. It works quite well!

    
    

    
  
(In reply to Michael Heyns from comment #11)
> Are there any remaining issues that are blocking this enhancement? 

All the blocking bugs have been closed.  

Time for someone to submit a patch, so we can get this in version 60. :)
Summary: reenable native Linux notifications by default → reenable native Linux notifications by default (disabled by bug 1144693 in version 40)

    
    

    
  


  
Assignee: nobody → jorgk
Status: NEW → ASSIGNED

        Attachment #8981772 -
        Flags: review?(mkmelin+mozilla)

        Attachment #8981772 -
        Flags: review?(acelists)

    
    

    
  
Nice work Jorg! Thanks for the patch. :-)

    
    

    
  
Comment on attachment 8981772 [details] [diff] [review]
1358837-native-linux-notification.patch

Review of attachment 8981772 [details] [diff] [review]:
-----------------------------------------------------------------

Yes let's do it, r=mkmelin

        Attachment #8981772 -
        Flags: review?(mkmelin+mozilla)

        Attachment #8981772 -
        Flags: review?(acelists)

        Attachment #8981772 -
        Flags: review+

    
    

    
  
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/a9755db5e412
re-enable native Linux notifications by default. r=mkmelin
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED

    
  
Target Milestone: --- → Thunderbird 62.0

    
    

    
  
Comment on attachment 8981772 [details] [diff] [review]
1358837-native-linux-notification.patch

[Triage Comment]

        Attachment #8981772 -
        Flags: approval-comm-esr60+

        Attachment #8981772 -
        Flags: approval-comm-beta+

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: