1358880 - Download directly shown as completed by toolbar button indicator after download start if private mode active, progressbar and time left/countdown missing

Status: RESOLVED INVALID

(Firefox :: Downloads Panel, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Latest Nightly 55.0a1 20170422 64-bit on Windows 8.1 64-bit

A download is directly shown as completed by the toolbar button indicator after the download started.

Steps to reproduce:
1. Open Firefox's Option.
2. Set Privacy > "Never remember history".
3. Restart Firefox.
4. Start a large download, e.g. http://www.sysresccd.org/Download

Actual result:
Download button directly shows download as completed.

Expected result:
Progressbar with estimated time left until download finished shown.

This is a regression from bug 1270006.

[Tracking Requested - why for this release]:
Regression of basic feature

Comment 1

[:Paolo Amadini]

Rex, do you confirm this regression?

Comment 2

[KM Lee [:rexboy] (inactivate after Sep. 22)]

I followed the STR but it works fine.

Let me confirm the situation:
We've decided to use download icon itself as progress bar and remove remaining time display in 1270006.
So not showing time is an expected behavior.
If the file have known size you can see the download icon lights part of its arrow to indicate the progress; otherwise user is just notified when download is completed.
If what you found is different, may you take a video for that?

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: download normal vs private mode.mp4

In this video, the first download of the file automatically opens the download button's menu. The second download which starts in private mode doesn't open that menu.

Comment 4

[:Paolo Amadini]

(In reply to Sebastian Hengst [:aryx][:archaeopteryx] (needinfo on intermittent or backout) from comment #3)
> In this video, the first download of the file automatically opens the
> download button's menu. The second download which starts in private mode
> doesn't open that menu.

The panel is designed to be shown automatically only the first time ever that a download starts on a profile.

That said, the contrast of the Downloads Indicator in the video when the download starts seems to be much lower than expected. Maybe it's an artifact of the compression. Sebastian, can you attach a small screenshot of the icon only, for Rex to check out?

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

attachment 8860950 [details] is a screenshot of the download button.

Comment 6

[KM Lee [:rexboy] (inactivate after Sep. 22)]

The contrast does look much lower than I expected. Seems it's because assets under Win8 or later uses a more brighter arrow for normal state of the download icon. 
If we're going to fix it without re-design the icon, with the same approach as bug 1338984, it will go to a much brighter color:
http://webaim.org/resources/contrastchecker/?fcolor=4d4d4d&bcolor=00b9ff

I can try on it and make a specified css rule for win8 or above. Maybe adjusting the icon so bright may decrease the quality of the icon a bit.

This issue is unrelated to the STR and title of this bug. If we're going to use this bug for it (assuming no duplicate?), we need to change title description and bug dependency (to bug 1338984).

Comment 7

[KM Lee [:rexboy] (inactivate after Sep. 22)]

http://webaim.org/resources/contrastchecker/?fcolor=4d4d4d&bcolor=00b9ff Sorry, correcting the wrong URL above.

Comment 8

[KM Lee [:rexboy] (inactivate after Sep. 22)]

http://webaim.org/resources/contrastchecker/?fcolor=797c80&bcolor=c5def8 Sorry again :-/ Should be this one.

Comment 9

[:Paolo Amadini]

(In reply to KM Lee [:rexboy] from comment #6)
> This issue is unrelated to the STR and title of this bug. If we're going to
> use this bug for it (assuming no duplicate?), we need to change title
> description and bug dependency (to bug 1338984).

Good point, let's use bug 1359062.